You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@apache.org> on 2013/04/26 20:51:27 UTC

Re: Review Request: Defer ApiDiscoveryServiceImpl load after db upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10802/
-----------------------------------------------------------

(Updated April 26, 2013, 6:51 p.m.)


Review request for cloudstack and Chip Childers.


Description
-------

Defer ApiDiscoveryServiceImpl load, which will read configuration db, while the db upgrade is not started yet, then cause bug: CLOUDSTACK-2194


This addresses bug CLOUDSTACK-2194.


Diffs
-----

  plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java b371488 
  plugins/api/discovery/test/org/apache/cloudstack/discovery/ApiDiscoveryTest.java afff746 

Diff: https://reviews.apache.org/r/10802/diff/


Testing
-------

ApiDiscoveryServiceImpl is loaded after db upgrade, then listApis works.


Thanks,

edison su

Re: Review Request: Defer ApiDiscoveryServiceImpl load after db upgrade

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10802/#review19798
-----------------------------------------------------------

Ship it!


Applied to 4.1.

Please make sure this gets into master!

- Chip Childers


On April 26, 2013, 6:51 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10802/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 6:51 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Defer ApiDiscoveryServiceImpl load, which will read configuration db, while the db upgrade is not started yet, then cause bug: CLOUDSTACK-2194
> 
> 
> This addresses bug CLOUDSTACK-2194.
> 
> 
> Diffs
> -----
> 
>   plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java b371488 
>   plugins/api/discovery/test/org/apache/cloudstack/discovery/ApiDiscoveryTest.java afff746 
> 
> Diff: https://reviews.apache.org/r/10802/diff/
> 
> 
> Testing
> -------
> 
> ApiDiscoveryServiceImpl is loaded after db upgrade, then listApis works.
> 
> 
> Thanks,
> 
> edison su
> 
>