You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/06/16 07:09:32 UTC

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3095: HDFS-16061. DFTestUtil.waitReplication can produce false positives

ayushtkn commented on a change in pull request #3095:
URL: https://github.com/apache/hadoop/pull/3095#discussion_r652409047



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
##########
@@ -206,6 +206,8 @@
   private static final String[] dirNames = {
     "zero", "one", "two", "three", "four", "five", "six", "seven", "eight", "nine"
   };
+
+  private static final int WAIT_REPLICATION_ATTEMPTS = 40;

Review comment:
       Why you have pulled this up? Means nobody apart from `waitReplication ` method is using it? We could have kept it there itself, the variable is private, no one can change it also




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org