You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/03/01 16:51:39 UTC
svn commit: r1573185 -
/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java
Author: sebb
Date: Sat Mar 1 15:51:39 2014
New Revision: 1573185
URL: http://svn.apache.org/r1573185
Log:
Don't write parameter
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java?rev=1573185&r1=1573184&r2=1573185&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/EnumUtils.java Sat Mar 1 15:51:39 2014
@@ -264,13 +264,13 @@ public class EnumUtils {
* @throws IllegalArgumentException if {@code enumClass} is not an enum class
* @since 3.2
*/
- public static <E extends Enum<E>> EnumSet<E> processBitVectors(final Class<E> enumClass, long... values) {
+ public static <E extends Enum<E>> EnumSet<E> processBitVectors(final Class<E> enumClass, final long... values) {
final EnumSet<E> results = EnumSet.noneOf(asEnum(enumClass));
- values = ArrayUtils.clone(Validate.notNull(values));
- ArrayUtils.reverse(values);
+ long[] lvalues = ArrayUtils.clone(Validate.notNull(values));
+ ArrayUtils.reverse(lvalues);
for (final E constant : enumClass.getEnumConstants()) {
final int block = constant.ordinal() / Long.SIZE;
- if (block < values.length && (values[block] & 1 << (constant.ordinal() % Long.SIZE)) != 0) {
+ if (block < lvalues.length && (lvalues[block] & 1 << (constant.ordinal() % Long.SIZE)) != 0) {
results.add(constant);
}
}
@@ -288,8 +288,8 @@ public class EnumUtils {
*/
private static <E extends Enum<E>> Class<E> checkBitVectorable(final Class<E> enumClass) {
final E[] constants = asEnum(enumClass).getEnumConstants();
- Validate.isTrue(constants.length <= Long.SIZE, CANNOT_STORE_S_S_VALUES_IN_S_BITS, constants.length,
- enumClass.getSimpleName(), Long.SIZE);
+ Validate.isTrue(constants.length <= Long.SIZE, CANNOT_STORE_S_S_VALUES_IN_S_BITS,
+ Integer.valueOf(constants.length), enumClass.getSimpleName(), Integer.valueOf(Long.SIZE));
return enumClass;
}