You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/02 20:08:15 UTC

[GitHub] [incubator-superset] micimize opened a new pull request #9456: Disable save button when can_add: false, can_overwrite: false

micimize opened a new pull request #9456: Disable save button when can_add: false, can_overwrite: false
URL: https://github.com/apache/incubator-superset/pull/9456
 
 
   fix #8302 (except the hotkey part)
   
   I put off fixing the hotkey copy because it isn't quite accurate anyways. For instance, you can't `ctrl-s` to save on a slice unless it exists and you have overwrite permissions, and on a mac `ctrl-r` doesn't work anyhow. 
   
   ### CATEGORY
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Disable chart save button when `can_add: false, can_overwrite: false`
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   before: ![image](https://user-images.githubusercontent.com/8343799/78296152-d7398480-74f2-11ea-892f-7cbef78913de.png)
   
   after: ![image](https://user-images.githubusercontent.com/8343799/78296127-cb4dc280-74f2-11ea-8b82-d0b70cc06422.png)
   
   
   ### TEST PLAN
   Configure a role such that it can view a chart but not edit/save it, then view a chart with that user.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: #8302
   - [X] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @willbarrett maybe?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on issue #9456: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9456: Disable save button when can_add: false, can_overwrite: false
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-609886591
 
 
   This looks reasonable to me. @nytai @rusackas does it look reasonable to you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] micimize commented on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
micimize commented on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637647742


   @villebro could you look this when you get the chance? It basically boils down to:
   ```diff
   <QueryAndSaveBtns 
   -  canAdd="True"
   +  canAdd={!!(this.props.can_add || this.props.can_overwrite)} 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9456      +/-   ##
   ==========================================
   - Coverage   71.35%   71.27%   -0.08%     
   ==========================================
     Files         585      585              
     Lines       30913    30800     -113     
     Branches     3246     3247       +1     
   ==========================================
   - Hits        22059    21954     -105     
   + Misses       8744     8736       -8     
     Partials      110      110              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.03% <100.00%> (+<0.01%)` | :arrow_up: |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `71.40% <ø> (-0.14%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `90.00% <ø> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.62% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.70% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.55% <0.00%> (-0.36%)` | :arrow_down: |
   | [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.06% <0.00%> (-0.29%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <0.00%> (-0.24%)` | :arrow_down: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.96%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9456      +/-   ##
   ==========================================
   - Coverage   71.35%   66.38%   -4.97%     
   ==========================================
     Files         585      585              
     Lines       30913    30800     -113     
     Branches     3246     3247       +1     
   ==========================================
   - Hits        22059    20448    -1611     
   - Misses       8744    10173    +1429     
   - Partials      110      179      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `71.33% <ø> (-0.21%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.00% <ø> (-20.00%)` | :arrow_down: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <100.00%> (-30.62%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `11.96%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9456       +/-   ##
   ===========================================
   - Coverage   71.35%   59.39%   -11.97%     
   ===========================================
     Files         585      401      -184     
     Lines       30913    12762    -18151     
     Branches     3246     3247        +1     
   ===========================================
   - Hits        22059     7580    -14479     
   + Misses       8744     5003     -3741     
   - Partials      110      179       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.00% <ø> (-20.00%)` | :arrow_down: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <100.00%> (-30.62%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [324 more](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9456      +/-   ##
   ==========================================
   - Coverage   71.35%   71.07%   -0.29%     
   ==========================================
     Files         585      585              
     Lines       30913    30800     -113     
     Branches     3246     3247       +1     
   ==========================================
   - Hits        22059    21892     -167     
   - Misses       8744     8793      +49     
   - Partials      110      115       +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.20% <100.00%> (-0.83%)` | :arrow_down: |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `71.40% <ø> (-0.14%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `90.00% <ø> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.62% <100.00%> (+0.15%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9456   +/-   ##
   =======================================
     Coverage   71.35%   71.35%           
   =======================================
     Files         585      585           
     Lines       30913    30914    +1     
     Branches     3246     3247    +1     
   =======================================
   + Hits        22059    22060    +1     
     Misses       8744     8744           
     Partials      110      110           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.03% <100.00%> (+<0.01%)` | :arrow_up: |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `71.54% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `90.00% <ø> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `77.62% <100.00%> (+0.15%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9456: fix: Disable save button when can_add: false, can_overwrite: false

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9456:
URL: https://github.com/apache/incubator-superset/pull/9456#issuecomment-637573502


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=h1) Report
   > Merging [#9456](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.92%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9456/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9456      +/-   ##
   ==========================================
   - Coverage   71.35%   66.42%   -4.93%     
   ==========================================
     Files         585      585              
     Lines       30913    30800     -113     
     Branches     3246     3247       +1     
   ==========================================
   - Hits        22059    20460    -1599     
   - Misses       8744    10161    +1417     
   - Partials      110      179      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.39% <100.00%> (+<0.01%)` | :arrow_up: |
   | #python | `71.40% <ø> (-0.14%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `70.00% <ø> (-20.00%)` | :arrow_down: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <100.00%> (-30.62%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/9456/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=footer). Last update [38a6bd7...cf515f8](https://codecov.io/gh/apache/incubator-superset/pull/9456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org