You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/07 21:38:00 UTC

[jira] [Commented] (GEODE-3270) Refactor StatusCommands

    [ https://issues.apache.org/jira/browse/GEODE-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117356#comment-16117356 ] 

ASF GitHub Bot commented on GEODE-3270:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/694

    GEODE-3270: Refactoring (renaming) StatusCommands

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3270)
    
    `StatusCommands` was a class that already contained a single command. A better-fitting name for the class is `StatusClusterConfigServiceCommand`.
    
    **TESTING STATUS: Precheckin in progress**
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Initial commit is single and squashed
    
    - [x] `gradlew build` runs cleanly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #694
    
----
commit fcf96b0e24a5a7a3ff93a11e4a5cdb3aa6127e49
Author: YehEmily <em...@gmail.com>
Date:   2017-08-07T21:32:43Z

    GEODE-3270: Refactoring (renaming) StatusCommands

----


> Refactor StatusCommands
> -----------------------
>
>                 Key: GEODE-3270
>                 URL: https://issues.apache.org/jira/browse/GEODE-3270
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{StatusCommands.java}} is a large class that contains multiple commands. Each command should be refactored into a separate class, and the methods shared by the commands should be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)