You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sjmshsh (via GitHub)" <gi...@apache.org> on 2023/09/23 11:50:34 UTC

[GitHub] [dubbo-kubernetes] sjmshsh opened a new pull request, #57: script, front, admin

sjmshsh opened a new pull request, #57:
URL: https://github.com/apache/dubbo-kubernetes/pull/57

   ## What is the purpose of the change
   
   XXXXX
   
   ## How to verify this change
   
   XXXX
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] chickenlj merged pull request #57: script, front, admin

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #57:
URL: https://github.com/apache/dubbo-kubernetes/pull/57


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] codecov-commenter commented on pull request #57: script, front, admin

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #57:
URL: https://github.com/apache/dubbo-kubernetes/pull/57#issuecomment-1732469294

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#57](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (db4d71d) into [master](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/bcd31acc40e8e3e48928655e1813508997e6082c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bcd31ac) will **increase** coverage by `0.01%`.
   > Report is 3 commits behind head on master.
   > The diff coverage is `8.69%`.
   
   > :exclamation: Current head db4d71d differs from pull request most recent head a6f8141. Consider uploading reports for the commit a6f8141 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master      #57      +/-   ##
   ==========================================
   + Coverage   47.39%   47.41%   +0.01%     
   ==========================================
     Files         150      150              
     Lines        9739     9740       +1     
     Branches       41       41              
   ==========================================
   + Hits         4616     4618       +2     
   + Misses       4593     4592       -1     
     Partials      530      530              
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [app/dubboctl/internal/dubbo/deployer.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2R1YmJvL2RlcGxveWVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [app/dubboctl/internal/dubbo/dubbo.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2R1YmJvL2R1YmJvLmdv) | `26.60% <0.00%> (ø)` | |
   | [app/dubboctl/cmd/build.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9idWlsZC5nbw==) | `19.13% <100.00%> (ø)` | |
   | [app/dubboctl/cmd/deploy.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9kZXBsb3kuZ28=) | `28.08% <100.00%> (ø)` | |
   
   ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/57/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] chickenlj commented on a diff in pull request #57: script, front, admin

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #57:
URL: https://github.com/apache/dubbo-kubernetes/pull/57#discussion_r1335272056


##########
pkg/webhook/patch/javasdk.go:
##########
@@ -19,20 +19,23 @@ import (
 	"strconv"
 
 	dubbo_cp "github.com/apache/dubbo-kubernetes/pkg/config/app/dubbo-cp"
-	"github.com/apache/dubbo-kubernetes/pkg/core/cert/provider"
+	"github.com/apache/dubbo-kubernetes/pkg/core/client/webhook"
 
 	v1 "k8s.io/api/core/v1"
+	"k8s.io/client-go/kubernetes"
 )
 
 type JavaSdk struct {

Review Comment:
   Give it a more general name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] sjmshsh commented on a diff in pull request #57: script, front, admin

Posted by "sjmshsh (via GitHub)" <gi...@apache.org>.
sjmshsh commented on code in PR #57:
URL: https://github.com/apache/dubbo-kubernetes/pull/57#discussion_r1335304879


##########
pkg/webhook/patch/javasdk.go:
##########
@@ -19,20 +19,23 @@ import (
 	"strconv"
 
 	dubbo_cp "github.com/apache/dubbo-kubernetes/pkg/config/app/dubbo-cp"
-	"github.com/apache/dubbo-kubernetes/pkg/core/cert/provider"
+	"github.com/apache/dubbo-kubernetes/pkg/core/client/webhook"
 
 	v1 "k8s.io/api/core/v1"
+	"k8s.io/client-go/kubernetes"
 )
 
 type JavaSdk struct {

Review Comment:
   ok, I will do it in the next pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org