You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/10/17 00:25:13 UTC

Review Request 63057: Moved and refactored some nested container tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63057/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Jie Yu.

Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305

Repository: mesos

Description
-------

This moves tests for the Nested container API found in `api_tests.cpp`
into `agent_container_api_tests.cpp` and refactors the moved tests to:
* Exercise the MesosContainerizer, rather than mocks.
* Parameterize tests to use the Standalone container API or Nested
container API.
* Parameterize tests to exercise different isolator combinations.

Additionally, the `NestedContainerWaitNotFound` and
`NestedContainerKillNotFound` tests are now combined into
`NestedContainerNotFound`.

From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`
respectively.

Diffs
-----

src/tests/agent_container_api_tests.cpp PRE-CREATION
src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a
src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5

Diff: https://reviews.apache.org/r/63057/diff/1/

Testing
-------

make check
sudo src/mesos-tests

On...
OSX and Ubuntu 16

Thanks,

Joseph Wu

Re: Review Request 63057: Moved and refactored some nested container tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63057/#review188257
-----------------------------------------------------------



Patch looks great!

Reviews applied: [61805, 61806, 60888, 60889, 60890, 60891, 62142, 62143, 62144, 62145, 63054, 63056, 63057]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 17, 2017, 12:25 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63057/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 12:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves tests for the Nested container API found in `api_tests.cpp`
> into `agent_container_api_tests.cpp` and refactors the moved tests to:
>   * Exercise the MesosContainerizer, rather than mocks.
>   * Parameterize tests to use the Standalone container API or Nested
>     container API.
>   * Parameterize tests to exercise different isolator combinations.
> 
> Additionally, the  `NestedContainerWaitNotFound` and
> `NestedContainerKillNotFound` tests are now combined into
> `NestedContainerNotFound`.
> 
> From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
> and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
> covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`
> respectively.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_container_api_tests.cpp PRE-CREATION 
>   src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
> 
> 
> Diff: https://reviews.apache.org/r/63057/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> sudo src/mesos-tests
> 
> On... 
> OSX and Ubuntu 16
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 63057: Moved and refactored some nested container tests.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63057/#review190477
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 2, 2017, 4 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63057/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 4 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves tests for the Nested container API found in `api_tests.cpp`
> into `agent_container_api_tests.cpp` and refactors the moved tests to:
>   * Exercise the MesosContainerizer, rather than mocks.
>   * Parameterize tests to use the Standalone container API or Nested
>     container API.
>   * Parameterize tests to exercise different isolator combinations.
> 
> Additionally, the  `NestedContainerWaitNotFound` and
> `NestedContainerKillNotFound` tests are now combined into
> `NestedContainerNotFound`.
> 
> From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
> and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
> covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`
> respectively.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_container_api_tests.cpp PRE-CREATION 
>   src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 
> 
> 
> Diff: https://reviews.apache.org/r/63057/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> On... 
> OSX and Ubuntu 16
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 63057: Moved and refactored some nested container tests.

Posted by Joseph Wu <jo...@mesosphere.io>.

(Updated Nov. 2, 2017, 9 a.m.)

Review request for mesos, Gilbert Song and Jie Yu.

Changes
-------

Rebase and propagate fixes from prior review.

Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305

Repository: mesos

Description
-------

Additionally, the `NestedContainerWaitNotFound` and
`NestedContainerKillNotFound` tests are now combined into
`NestedContainerNotFound`.

Diffs (updated)
-----

src/tests/agent_container_api_tests.cpp PRE-CREATION
src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5
src/tests/containerizer/nested_mesos_containerizer_tests.cpp fbd2887800ccfd64c8628c5d6fd77a511c8f91d5

Diff: https://reviews.apache.org/r/63057/diff/2/

Changes: https://reviews.apache.org/r/63057/diff/1-2/

Testing (updated)
-------

make check

On...
OSX and Ubuntu 16

Thanks,

Joseph Wu

Re: Review Request 63057: Moved and refactored some nested container tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63057/#review188258
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 61805.

Failed command: `python.exe .\support\apply-reviews.py -n -r 61805`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63057

Relevant logs:

- [apply-review-61805-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63057/logs/apply-review-61805-stdout.log):

```
error: patch failed: src/slave/paths.cpp:69
error: src/slave/paths.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 17, 2017, 12:25 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63057/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 12:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves tests for the Nested container API found in `api_tests.cpp`
> into `agent_container_api_tests.cpp` and refactors the moved tests to:
>   * Exercise the MesosContainerizer, rather than mocks.
>   * Parameterize tests to use the Standalone container API or Nested
>     container API.
>   * Parameterize tests to exercise different isolator combinations.
> 
> Additionally, the  `NestedContainerWaitNotFound` and
> `NestedContainerKillNotFound` tests are now combined into
> `NestedContainerNotFound`.
> 
> From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
> and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
> covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`
> respectively.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_container_api_tests.cpp PRE-CREATION 
>   src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
> 
> 
> Diff: https://reviews.apache.org/r/63057/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> sudo src/mesos-tests
> 
> On... 
> OSX and Ubuntu 16
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>