You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/10 19:50:37 UTC

[GitHub] [tvm] tkonolige opened a new pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

tkonolige opened a new pull request #7631:
URL: https://github.com/apache/tvm/pull/7631


   This PR uses the device timers introduced in #7472 to provide more accurate timing results when using the time evaluator. Specifically, synchronization time (between device and cpu) is no longer included in total runtime.
   
   @areusch @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7631:
URL: https://github.com/apache/tvm/pull/7631


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7631:
URL: https://github.com/apache/tvm/pull/7631#issuecomment-796125382


   Hey Tristan, I just noticed that `tests/cpp/profiling.cc` is not included in the cpptest in CI, because the script only runs those ends with `_test` 🤦‍♂️. Would you like to rename this file to `profiling_test.cc` in this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7631:
URL: https://github.com/apache/tvm/pull/7631#issuecomment-796129845


   Thats a big whoops from me! I've moved it to `tests/cpp/profiling_test.cc`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 edited a comment on pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

Posted by GitBox <gi...@apache.org>.
junrushao1994 edited a comment on pull request #7631:
URL: https://github.com/apache/tvm/pull/7631#issuecomment-796125382


   Hey Tristan, I just noticed that `tests/cpp/profiling.cc` is not included in the cpptest in CI, because the cpptest script only runs those end with `_test` 🤦‍♂️. Would you like to rename this file to `profiling_test.cc` in this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #7631: [RUNTIME] Switch time evaluator to use device specific timing.

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7631:
URL: https://github.com/apache/tvm/pull/7631#issuecomment-796909414


   Double whoops: I made that change in #7624


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org