[GitHub] [pinot] chenboat commented on a diff in pull request #10888: Close PinotFS after Data Manager Shutdowns

["chenboat (via GitHub)" <gi...@apache.org>]

chenboat commented on code in PR #10888:
URL: https://github.com/apache/pinot/pull/10888#discussion_r1227177967


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -648,6 +642,14 @@ public void stop() {
     }
     _serverQueriesDisabledTracker.stop();
     _realtimeLuceneIndexRefreshState.stop();
+    try {
+      // Close PinotFS after all data managers are shutdown. Otherwise, committing segments might not be able to

Review Comment:
   committng segments --> committing servers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org