[GitHub] [shardingsphere] fang1025 commented on a diff in pull request #21768: fix ShardingSphereResultSet bug.

[GitBox <gi...@apache.org>]

fang1025 commented on code in PR #21768:
URL: https://github.com/apache/shardingsphere/pull/21768#discussion_r1012742870


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/impl/ShorthandProjection.java:
##########
@@ -39,10 +39,17 @@ public final class ShorthandProjection implements Projection {
     private final String owner;
     
     private final Map<String, ColumnProjection> actualColumns = new LinkedHashMap<>();
-    
-    public ShorthandProjection(final String owner, final Collection<ColumnProjection> columnProjections) {
+
+    private final Map<String, Projection> resultSetColumns = new LinkedHashMap<>();

Review Comment:
   actualColumns is used in  'shardingsphere-encrypt-core' project.  
   
   I will confirm whether SHARDINGSPHERE-ENCRYPT-CORE can accept ExpressionProjection&ColumnProjection  instead of ColumnProjection .
   
   then I will reply to you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org