[jira] [Commented] (GEODE-7597) Factor out code needed in Membership from SocketCreator

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024772#comment-17024772 ] 

ASF subversion and git services commented on GEODE-7597:
--------------------------------------------------------

Commit 31ea0bfc93cd9d49231acf312499b51e77a30569 in geode's branch refs/heads/feature/GEODE-7597 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=31ea0bfc ]

GEODE-7597: Factor out code needed in Membership from SocketCreator

Implemented a new TcpSocketCreatorImpl.  Due to GeodeHttpClientRule
dependencies this and associated interfaces are in geode-common.  I'd
rather have them in geode-tcp-server.

SocketCreator now subclasses TcpSocketCreatorImpl and I've removed the
adapter class, which is no longer needed.


> Factor out code needed in Membership from SocketCreator
> -------------------------------------------------------
>
>                 Key: GEODE-7597
>                 URL: https://issues.apache.org/jira/browse/GEODE-7597
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Bill Burcham
>            Priority: Major
>
> {{SocketCreator}} is part of {{geode-core}}. But we need a {{TcpSocketCreator}} to test membership. Rather than creating a new implementation of {{TcpSocketCreator}} used only in tests, we'll factor out the code from {{SocketCreator}} into TBD class/TBD module for use by both {{SocketCreator}} and membership tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)