You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/10/05 16:38:58 UTC

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20537


Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................

IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Not all RPC need to print logs at VLOG level 2. For example,
StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1
second. Debug impalad through lowering VLOG lovel to 2 has been
difficult due to noise from this StatestoreSubscriber.UpdateState RPC
that buries other more important log lines.

This patch add vlog_level parameter in RpcEventHandler to make log level
for different kind of RPC adjustable.

Testing:
- Manually test that log lines from StatestoreSubscriber.UpdateState is
  not printed anymore after lowering backend VLOG level to 2.

Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
---
M be/src/rpc/rpc-trace.cc
M be/src/rpc/rpc-trace.h
M be/src/statestore/statestore-subscriber.cc
3 files changed, 17 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/20537/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:01:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc@221
PS1, Line 221:   // levels.
> maybe add a new #define for this class of logging?
Done.
I think new #define is too much for now.



-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:00:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc@221
PS1, Line 221:       new RpcEventHandler("statestore-subscriber", metrics_, 3));
> nit: add a comment about what the 3 here means, like "Logging statestore su
maybe add a new #define for this class of logging?



-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 16:47:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 22:33:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14142/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:06:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:01:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20537

to look at the new patch set (#2).

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................

IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Not all RPC need to print logs at VLOG level 2. For example,
StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1
second. Debugging impalad through lowering VLOG lovel to 2 has been
difficult due to noise from this StatestoreSubscriber.UpdateState RPC
that buries other more important log lines.

This patch add vlog_level parameter in RpcEventHandler to make log level
for different kind of RPC adjustable.

Testing:
- Manually test that log lines from StatestoreSubscriber.UpdateState is
  not printed anymore after lowering backend VLOG level to 2.

Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
---
M be/src/rpc/rpc-trace.cc
M be/src/rpc/rpc-trace.h
M be/src/statestore/statestore-subscriber.cc
3 files changed, 19 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/20537/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Removed Code-Review+1 by Michael Smith <mi...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9791/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 18:13:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I've definitely run into this, seems useful.

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:

http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc@221
PS1, Line 221:       new RpcEventHandler("statestore-subscriber", metrics_, 3));
nit: add a comment about what the 3 here means, like "Logging statestore subscriber heartbeats at VLOG_RPC to avoid overwhelming lower log levels."



-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 16:42:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14143/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:22:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 17:01:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20537 )

Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable
......................................................................

IMPALA-12482: Make VLOG level of RpcEventHandler adjustable

Not all RPC need to print logs at VLOG level 2. For example,
StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1
second. Debugging impalad through lowering VLOG lovel to 2 has been
difficult due to noise from this StatestoreSubscriber.UpdateState RPC
that buries other more important log lines.

This patch add vlog_level parameter in RpcEventHandler to make log level
for different kind of RPC adjustable.

Testing:
- Manually test that log lines from StatestoreSubscriber.UpdateState is
  not printed anymore after lowering backend VLOG level to 2.

Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Reviewed-on: http://gerrit.cloudera.org:8080/20537
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/rpc/rpc-trace.cc
M be/src/rpc/rpc-trace.h
M be/src/statestore/statestore-subscriber.cc
3 files changed, 19 insertions(+), 9 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, but someone else must approve
  Michael Smith: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add
Gerrit-Change-Number: 20537
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>