You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/01/14 19:08:34 UTC
[jira] Created: (HADOOP-2599) [hbase] Some minor improvements to
changes in HADOOP-2443
[hbase] Some minor improvements to changes in HADOOP-2443
---------------------------------------------------------
Key: HADOOP-2599
URL: https://issues.apache.org/jira/browse/HADOOP-2599
Project: Hadoop
Issue Type: Improvement
Reporter: Bryan Duxbury
Priority: Minor
Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
Here in HConnectionManager:
+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);
... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
Here:
+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);
.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");
[ Show » ]
stack - 13/Jan/08 10:54 PM Committed. Had some minor questions - see below - but it ain't enough to hold up patch and I'm afraid patch would rot if left hang (It touches lots of classes). Resolving. Thanks for the patch Bryan. Here's the couple of items: Here in HConnectionManager:
+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);
... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?). Here:
+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);
.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think? This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HADOOP-2599) [hbase] Some minor improvements
to changes in HADOOP-2443
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-2599 started by Bryan Duxbury.
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 2599.patch
>
>
> Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2599) [hbase] Some minor improvements to
changes in HADOOP-2443
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2599:
----------------------------------
Component/s: contrib/hbase
Assignee: Bryan Duxbury
Description:
Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
Here in HConnectionManager:
+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);
... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
Here:
+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);
.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");
was:
Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
Here in HConnectionManager:
+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);
... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
Here:
+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);
.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");
[ Show » ]
stack - 13/Jan/08 10:54 PM Committed. Had some minor questions - see below - but it ain't enough to hold up patch and I'm afraid patch would rot if left hang (It touches lots of classes). Resolving. Thanks for the patch Bryan. Here's the couple of items: Here in HConnectionManager:
+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);
... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?). Here:
+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);
.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think? This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2599) [hbase] Some minor improvements to
changes in HADOOP-2443
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558708#action_12558708 ]
Bryan Duxbury commented on HADOOP-2599:
---------------------------------------
@stack: Regarding the third suggestion, are you indicating that we need a new class to hold a method that can append an unreasonably large timestamp onto a table name? Does the method seem complex enough to warrant that? If we create an HTableInfo class, what else would go in it?
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2599) [hbase] Some minor improvements to
changes in HADOOP-2443
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2599:
----------------------------------
Attachment: 2599.patch
Here's a patch that implements the first two suggestions.
> [hbase] Some minor improvements to changes in HADOOP-2443
> ---------------------------------------------------------
>
> Key: HADOOP-2599
> URL: https://issues.apache.org/jira/browse/HADOOP-2599
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 2599.patch
>
>
> Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:
> Here in HConnectionManager:
> + scannerId = server.openScanner(
> + metaLocation.getRegionInfo().getRegionName(),
> + COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
> + null);
> ... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).
> Here:
> + } while (startRow.compareTo(EMPTY_START_ROW) != 0);
> .. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?
> This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:
> + Text tableKey = new Text(tableName.toString() + ",,99999999999999");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.