You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/12/02 17:52:47 UTC
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19314
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/1
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11952/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 19:01:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#2).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/2
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py@61
PS5, Line 61:
> nit: maybe it is useful to print "WARNING" and tell user to be careful to n
Done. Added some color to make it stand out.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:43:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 8: Verified+1 Code-Review+2
Carrying the +2. This is a new binary with a name used nowhere in the project.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 19:19:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:17:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#7).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/7
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 8: Code-Review+2
Carrying the +2.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:55:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19314/6/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/6/bin/inline_pom.py@67
PS6, Line 67: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/19314/6/bin/inline_pom.py@69
PS6, Line 69: \
flake8: E502 the backslash is redundant between brackets
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:43:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11953/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 19:02:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Reviewed-on: http://gerrit.cloudera.org:8080/19314
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
A bin/inline_pom.py
1 file changed, 72 insertions(+), 0 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11948/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:10:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#3).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 62 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/3
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Removed Code-Review+2 by Michael Smith <mi...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py@61
PS5, Line 61: print("Replacing environment variables in {}".format(', '.join(sys.argv[1:])))
nit: maybe it is useful to print "WARNING" and tell user to be careful to not commit inlined pom.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:20:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19314/7/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/7/bin/inline_pom.py@67
PS7, Line 67: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/19314/7/bin/inline_pom.py@69
PS7, Line 69: \
flake8: E502 the backslash is redundant between brackets
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:44:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11955/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 19:11:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#4).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 63 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/4
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11949/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:16:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#6).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/6
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#8).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/8
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11951/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:33:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@22
PS4, Line 22: # Usage: inline_pom.py pom.xml
> Nit: Commit message says usage is "inline_pom.py fe/pom.xml java/**/pom.xml
Well, the commit message shows how to find all the relevant pom files, but this I was leaving more generic.
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@38
PS4, Line 38: print("export {}={}".format(name, value))
> This is just diagnostics?
Yes. I might remove the export; I was experimenting with adding it to my laptop environment but it didn't help.
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@58
PS4, Line 58: print("Usage: inline_pom.py <pom.xml>...")
> Nit: Make usage notes consistent
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:16:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Looks good, please carry +2 if you change anything
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@22
PS4, Line 22: # Usage: inline_pom.py pom.xml
Nit: Commit message says usage is "inline_pom.py fe/pom.xml java/**/pom.xml"
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@38
PS4, Line 38: print("export {}={}".format(name, value))
This is just diagnostics?
http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@58
PS4, Line 58: print("Usage: inline_pom.py <pom.xml>...")
Nit: Make usage notes consistent
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 18:14:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19314
to look at the new patch set (#5).
Change subject: [tools] Add inline_pom.py script for development
......................................................................
[tools] Add inline_pom.py script for development
Adds inline_pom.py, which can be run as
inline_pom.py fe/pom.xml java/**/pom.xml
to perform environment substitution. This makes POM files usable by
VSCode and in remote development where environment variables may not be
available to IDE language servers and other features.
Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
---
A bin/inline_pom.py
1 file changed, 63 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/19314/5
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Add inline pom.py script for development
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/19314/1/bin/inline_pom.py
File bin/inline_pom.py:
http://gerrit.cloudera.org:8080/#/c/19314/1/bin/inline_pom.py@36
PS1, Line 36: def inline_envs(line):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/19314/1/bin/inline_pom.py@46
PS1, Line 46: def update_pom(pom_path):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/19314/1/bin/inline_pom.py@49
PS1, Line 49: ,
flake8: E231 missing whitespace after ','
http://gerrit.cloudera.org:8080/#/c/19314/1/bin/inline_pom.py@57
PS1, Line 57: print("Replacing environment variables in {}".format(', '.join(sys.argv[1:])))
flake8: E305 expected 2 blank lines after class or function definition, found 1
--
To view, visit http://gerrit.cloudera.org:8080/19314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4
Gerrit-Change-Number: 19314
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 17:53:43 +0000
Gerrit-HasComments: Yes