You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/12/30 12:03:13 UTC

[royale-asjs] branch develop updated: jewel-listview-tableview: fix issue in DateChooser reported by Piotr when click on years button. there was a problem caused by recent fix on listview selection and scrolltoIndex performed by non clicked actions

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new f7f0b97  jewel-listview-tableview: fix issue in DateChooser reported by Piotr when click on years button. there was a problem caused by recent fix on listview selection and scrolltoIndex performed by non clicked actions
f7f0b97 is described below

commit f7f0b97a7349c0f530e3fb9fc1c0da7a9c63cf9b
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Dec 30 13:02:55 2020 +0100

    jewel-listview-tableview: fix issue in DateChooser reported by Piotr when click on years button. there was a problem caused by recent fix on listview selection and scrolltoIndex performed by non clicked actions
---
 .../royale/org/apache/royale/jewel/beads/views/ListView.as | 14 +++++++++++++-
 .../org/apache/royale/jewel/beads/views/TableView.as       |  5 +++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ListView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ListView.as
index b33a069..dfba1ee 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ListView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ListView.as
@@ -133,7 +133,14 @@ package org.apache.royale.jewel.beads.views
 			
 			lastSelectedIndex = listModel.selectedIndex;
 
-			// if the selection was not from a user click selection, then scrol to index
+			itemClickedAction();
+		}
+
+		/**
+		 * if the selection was not from a user click selection, then scrol to index
+		 */
+		protected function itemClickedAction():void
+		{
 			if(!(listModel as IJewelSelectionModel).isItemClicked)
 			{
 				scrollToIndex(lastSelectedIndex);
@@ -306,6 +313,11 @@ package org.apache.royale.jewel.beads.views
 			lastSelectedIndex = listModel.selectedIndex;
 		}
 
+		protected function itemClickedAction():void
+		{
+		
+		}
+		
 		protected var lastRollOverIndex:int = -1;
 
 		/**
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as
index 569ff9e..165fae2 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/TableView.as
@@ -61,6 +61,11 @@ package org.apache.royale.jewel.beads.views
 			listModel.addEventListener("columnsChanged", columnsChangedHandler);
 		}
 
+		override protected function itemClickedAction():void
+		{
+			// nothing to do
+		}
+
 		/**
 		 * When columns change, trigger a data provider change to redo all table
 		 */