You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by omefire <gi...@git.apache.org> on 2015/06/03 23:12:27 UTC
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/214
CB-9114: Deprecating the --usegit flag
CB-9114: Deprecating the --usegit flag
Background:
http://apache.markmail.org/message/7cf5zovxcgdxgwa2?q=ommenjik+list:org%2Eapache%2Eincubator%2Ecallback-dev+order:date-backward&page=1#query:ommenjik%20list%3Aorg.apache.incubator.callback-dev%20order%3Adate-backward+page:1+mid:c3cep6d3eez5kefe+state:results
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-cli CB-9114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #214
----
commit 69f0e152356622300a67153ad8a435f0cc22fdeb
Author: Omar Mefire <om...@microsoft.com>
Date: 2015-06-03T20:44:27Z
CB-9114: Deprecation Warning for --usegit flag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/214#issuecomment-112176978
Related PR : https://github.com/apache/cordova-lib/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/214#issuecomment-116874574
@nikhilkh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/214#discussion_r32484109
--- Diff: doc/platform.txt ---
@@ -5,7 +5,10 @@ Synopsis
Manage project platforms
add <plat-spec> [...].............. add specified platforms
- --usegit ...................... retrieve from git instead of npm registry
+ --usegit ...................... [WARNING: This flag has been deprecated !]
+ [Instead, please use: `cordova platform add git-url#custom-branch`.]
+ [e.g: cordova platform add https://github.com/apache/cordova-android.git#2.4.0]
+ retrieve from git instead of npm registry
--- End diff --
Just a minor nit, as for the other change - don't put a space before the `!` (or just replace it with a period). Also, I wonder - should the description come first, then the warning?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/214#discussion_r33171432
--- Diff: doc/platform.txt ---
@@ -5,7 +5,10 @@ Synopsis
Manage project platforms
add <plat-spec> [...].............. add specified platforms
- --usegit ...................... retrieve from git instead of npm registry
+ --usegit ...................... [WARNING: This flag has been deprecated !]
+ [Instead, please use: `cordova platform add git-url#custom-branch`.]
+ [e.g: cordova platform add https://github.com/apache/cordova-android.git#2.4.0]
+ retrieve from git instead of npm registry
--- End diff --
I think the warning should come first, to immediately catch the user's attention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org