[GitHub] [hive] cmunkey commented on a diff in pull request #3444: AS[]: Dump Tables in parallel

[GitBox <gi...@apache.org>]

cmunkey commented on code in PR #3444:
URL: https://github.com/apache/hive/pull/3444#discussion_r932570446


##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java:
##########
@@ -1937,4 +1937,84 @@ public void testSingleCopyTasksConfiguration(boolean runCopyTasksOnTarget)
     // Clean up the filter file.
     new File(filterFilePath).delete();
   }
+
+  @Test
+  public void testTableAndPartitionExportDumpWithParallelism() throws Throwable {
+    testTableExportDumpParallelism(true);
+  }
+
+  @Test
+  public void testTableAndPartitionExportDumpWithNoParallelism() throws Throwable {
+    testTableExportDumpParallelism(false);
+  }
+
+  public void testTableExportDumpParallelism(boolean enableParallelism) throws Throwable {
+    List<String> tableList = new ArrayList<String>();
+    List<String> withClause = ReplicationTestUtils.includeExternalTableClause(true);
+    if (enableParallelism) {
+      withClause.add("'" + HiveConf.ConfVars.REPL_EXPORT_DUMP_PARALLELISM.varname + "'='100'");
+    }
+
+    primary.run("use " + primaryDbName);
+
+    // create 10 partitioned tables.

Review Comment:
   Can you add managed tables as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org