You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/04/25 03:54:08 UTC
[jira] [Commented] (HDFS-3319) DFSOutputStream should not start a
thread in constructors
[ https://issues.apache.org/jira/browse/HDFS-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261232#comment-13261232 ]
Hadoop QA commented on HDFS-3319:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12524090/h3319_20120424.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.TestUrlStreamHandler
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2326//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2326//console
This message is automatically generated.
> DFSOutputStream should not start a thread in constructors
> ---------------------------------------------------------
>
> Key: HDFS-3319
> URL: https://issues.apache.org/jira/browse/HDFS-3319
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h3319_20120424.patch
>
>
> DFSOutputStream starts the DataStreamer thread in its constructors. This is a known bad programming practice. It will generate findbugs warnings if the class is not final.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira