You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:13:02 UTC
[GitHub] [brooklyn-ui] grkvlt opened a new pull request, #324: Adds recursive LogBook query feature
grkvlt opened a new pull request, #324:
URL: https://github.com/apache/brooklyn-ui/pull/324
WIP
Requires brooklyn-server#1316
Signed-off-by: Andrew Donald Kennedy <an...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1150844183
<img width="246" alt="Screenshot 2022-06-09 at 09 44 32" src="https://user-images.githubusercontent.com/81319331/172804993-73e34e2b-c245-45ce-8ad2-3086d8142f84.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1150842294
I suggest to pick a different icon for this, it is not clear which arrow means what as they are similar, besides, there is a styling clash.
https://user-images.githubusercontent.com/81319331/172804314-288b8354-8e1f-416f-8233-e85857dad7c1.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim merged pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim merged PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1151050464
https://github.com/apache/brooklyn-ui/pull/331 with changed icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1150889352
Merging this. I'll open a separate PR to address icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] jcabrerizo commented on a diff in pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on code in PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#discussion_r881712252
##########
ui-modules/utils/logbook/logbook.template.html:
##########
@@ -59,6 +59,11 @@
<i class="fa fa-share" ng-class="{'fa-rotate-90': search.latest, 'fa-rotate-270': !search.latest}"></i>
</button>
</div>
+ <div class="btn-group">
+ <button id="logbook-recursive" type="button" ng-click="search.recursive = !search.recursive" class="btn btn-default btn-accent" uib-dropdown-toggle uib-tooltip="Recursive selection of task children">
Review Comment:
I think the tooltip message should be a little more user friendly: "Show subtask" or "Show child task recursively"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1150848096
Styling clash when both activated.
<img width="244" alt="Screenshot 2022-06-09 at 09 48 16" src="https://user-images.githubusercontent.com/81319331/172805778-89b2a58a-d49f-4f76-84c0-2ce465666f74.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1150844737
I suggest to pick a different icon for this, it is not clear which arrow means what as they are similar, besides, there is a styling clash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #324: Adds recursive LogBook query feature
Posted by GitBox <gi...@apache.org>.
algairim commented on PR #324:
URL: https://github.com/apache/brooklyn-ui/pull/324#issuecomment-1151050088
https://github.com/apache/brooklyn-ui/pull/331 with changed icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org