[GitHub] [superset] villebro commented on pull request #17511: fix: Dashboard access when DASHBOARD_RBAC is disabled

[GitBox <gi...@apache.org>]

villebro commented on pull request #17511:
URL: https://github.com/apache/superset/pull/17511#issuecomment-976247249


   > The original intention here was to keep the old behaviour before DASHBOARD_RBAC era where there was no enforcement to dashboard access at all
   > 
   > But I agree that access should be enforced.
   > 
   > There was another idea by @dpgaspar That We might want to consider switching to 404 this would prevent malicious API calls from finding out which dashboard IDs exist and which are not.
   > 
   > Altough personaly I prefer 403
   
   Right, I remember we were pretty prudent during review in making sure the behavior was unchanged when the feature flag was disabled. Regarding 403/404 , I'm also more a 403 type of guy for this sort of stuff, but I'm ok with 404 if that's the security pattern we've chosen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org