You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/25 01:43:53 UTC
Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4
Diff: https://reviews.apache.org/r/17345/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 27, 2014, 6:56 p.m., Jie Yu wrote:
> > src/java/jni/org_apache_mesos_Log.cpp, line 442
> > <https://reviews.apache.org/r/17345/diff/1/?file=450720#file450720line442>
> >
> > This should be 'break', right?
And now the new log test is passing! ;)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review32851
-----------------------------------------------------------
On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 12:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review32851
-----------------------------------------------------------
src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/17345/#comment61849>
This should be 'break', right?
src/log/log.hpp
<https://reviews.apache.org/r/17345/#comment61853>
Comments need to be adjusted. Seems that currently, multiple writers can be 'valid', but only one of them has 'started'.
- Jie Yu
On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 12:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review36345
-----------------------------------------------------------
Bad patch!
Reviews applied: [17345]
Failed command: git apply --index 17345.patch
Error:
error: patch failed: src/log/log.hpp:152
error: src/log/log.hpp: patch does not apply
error: patch failed: src/log/log.cpp:167
error: src/log/log.cpp: patch does not apply
error: patch failed: src/tests/log_tests.cpp:1457
error: src/tests/log_tests.cpp: patch does not apply
- Mesos ReviewBot
On Feb. 19, 2014, 8:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:03 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 4, 2014, 2:11 a.m., Ben Mahler wrote:
> > src/tests/log_tests.cpp, lines 1462-1464
> > <https://reviews.apache.org/r/17345/diff/2/?file=497565#file497565line1462>
> >
> > Do you need to store 'start'?
> >
> > AWAIT_READY(writer.start());
Yes, I should check that start returned some position! Fixed.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review36061
-----------------------------------------------------------
On Feb. 19, 2014, 8:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:03 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review36061
-----------------------------------------------------------
Ship it!
src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/17345/#comment66962>
I see this was a copy/paste, but couldn't this just be:
while (retries-- > 0) {
}
or
for (int attempt = 0; attempt <= retries; ++attempts) {
src/log/log.cpp
<https://reviews.apache.org/r/17345/#comment66893>
Is 'Failed' the right wording for an INFO message?
src/log/log.cpp
<https://reviews.apache.org/r/17345/#comment66964>
It's unfortunate that the initial Failure returned to the caller will only contain 'reason' and the subsequent calls that check 'error' will return a Failure that includes both 'message' and 'reason'.
src/tests/log_tests.cpp
<https://reviews.apache.org/r/17345/#comment66967>
Do you need to store 'start'?
AWAIT_READY(writer.start());
- Ben Mahler
On Feb. 19, 2014, 8:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:03 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/#review35334
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 19, 2014, 8:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17345/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:03 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17345/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17345: Replaced Log::Writer constructor with explicit
Log::Writer::start.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17345/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 8:03 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updates from review comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_Log.cpp 36c636d155c1581eeb7734cdbc5b6fac4ca42440
src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4
src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
Diff: https://reviews.apache.org/r/17345/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman