You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 07:54:37 UTC

[GitHub] [flink] twalthr commented on a diff in pull request #19566: [FLINK-27369][table-planner] Fix the type mismatch error in RemoveUnreachableCoalesceArgumentsRule

twalthr commented on code in PR #19566:
URL: https://github.com/apache/flink/pull/19566#discussion_r857350481


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/RemoveUnreachableCoalesceArgumentsRuleTest.java:
##########
@@ -83,4 +83,27 @@ public void testJoinCoalesce() {
         util.verifyRelPlan(
                 "SELECT * FROM T t1 LEFT JOIN T t2 ON COALESCE(t1.f0, '-', t1.f2) = t2.f0");
     }
+
+    @Test
+    public void testMultipleCoalesces() {

Review Comment:
   This test is not super helpful as it is unable to test to final result type. Can you add at least a single test to `CoalesceFunctionITCase`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org