You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ariatosca.apache.org by djay87 <gi...@git.apache.org> on 2017/07/18 10:33:52 UTC
[GitHub] incubator-ariatosca pull request #186: ARIA-277 Support for Type Qualified N...
GitHub user djay87 opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/186
ARIA-277 Support for Type Qualified Name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djay87/incubator-ariatosca master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #186
----
commit 740df7062f536e8716acc07013adf05745cdd172
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-11T10:35:29Z
ARIA-277 Support for Type Qualified Name
commit c4a56b44ecfa96f9f8412f1fb3dfdf1920f6e5e9
Author: djay87 <d....@ericsson.com>
Date: 2017-07-11T10:53:59Z
Merge branch 'master' into master
commit 640bcf25056e157959f7cf789dea586f4d950927
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-11T13:37:38Z
ARIA-277 Support for Type Qualified Name
commit 6214e507b920ff0d4f32486f0cf9b313db09efc7
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-17T10:34:36Z
ARIA-277 Support for Type Qualified Name
commit f59a3ee4b441c76c846c258131a880f15a10329c
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-17T12:40:46Z
ARIA-277 Support for Type Qualified Name
commit 9e07d7d18479726ce50e1888f76089218a2410ef
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-17T12:41:42Z
Merge branch 'master' of https://github.com/djay87/incubator-ariatosca
commit 2871a26f7c08bab016a9174c5f759785a36e7bdc
Author: evyzzae <d....@ericsson.com>
Date: 2017-07-17T13:45:47Z
ARIA-277 Support for Type Qualified Name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
looks good :smiley: will merge into master shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #186: ARIA-277 Support for Type Qualified N...
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 closed the pull request at:
https://github.com/apache/incubator-ariatosca/pull/186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
This PR was merged to master, can you please erase the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
Thanks max. I hope erasing the PR means closing this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
Could you please check if all my commits are squashed now ? Am bit new to this squash concept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
Yeah, no problem. Basically as long as github says this PR has 9 commits, the commits were not fully squashed. you can find a quick answer to how to squash [here](https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git), but please be careful, i would copy the working dir for the forked repo and try squashing from that copy (only when you are 100% sure all of your changes are present in the single commit, you should push back to your branch).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca issue #186: ARIA-277 Support for Type Qualified Name
Posted by djay87 <gi...@git.apache.org>.
Github user djay87 commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/186
Hi Max,
Finally i was able to squash all the commits and resolve the merge issue with a single commit. Kindly check and let me know if its fine this time :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---