You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/20 18:51:29 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #9637: [Bug][DAO] Update db init script and soft_version (#9628)

EricGao888 opened a new pull request, #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637

   ## Purpose of the pull request
   * Fix bugs in db init script, as described here:
   https://github.com/apache/dolphinscheduler/issues/9628#issuecomment-1104274868
   * Update `soft_version`
   * Duplicate errors stated in https://github.com/apache/dolphinscheduler/issues/9628#issuecomment-1104274868 caused by `dolphinscheduler-dao/src/main/resources/sql/upgrade/2.1.0_schema` are not handled in this PR. Therefore, #9628 should NOT be closed until these errors are fixed.
   
   ## Brief change log
   * Described above
   
   ## Verify this pull request
   * Compile the project and check output `create_schema.sh` and `soft_version` are as expected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#discussion_r854716675


##########
dolphinscheduler-dao/src/main/resources/sql/soft_version:
##########
@@ -1 +1 @@
-2.0.4
+3.0.0

Review Comment:
   Sorry for the reply later. Our version in `pom.xml` use version `dev` but we here use `3.0.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104647763

   > @EricGao888 Would you please add these configure steps to docs? Thanks.
   
   @SbloodyS Sure, I will link a new PR to this one: #9598 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104659666

   > > +1
   > 
   > @SbloodyS @caishunfeng Just curious, I think db initialization is a basic and vital operation. Not sure why this bug hasn't been detected by our CI. Should I open an issue to add a check for this in CI?
   
   Currently cluster ```start/stop/create/upgrade``` steps test does not included in our CI. I'm working on it in #9474 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104363413

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9637](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f54e79) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/239be31ab732f5bbe68fca3033245125e8388657?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (239be31) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #9637      +/-   ##
   ============================================
   - Coverage     39.88%   39.87%   -0.01%     
   + Complexity     4452     4451       -1     
   ============================================
     Files           835      835              
     Lines         33537    33537              
     Branches       3705     3705              
   ============================================
   - Hits          13375    13373       -2     
   - Misses        18923    18924       +1     
   - Partials       1239     1240       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.96% <0.00%> (-1.64%)` | :arrow_down: |
   | [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `53.33% <0.00%> (-1.34%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [239be31...0f54e79](https://codecov.io/gh/apache/dolphinscheduler/pull/9637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#discussion_r854743242


##########
dolphinscheduler-dao/src/main/resources/sql/soft_version:
##########
@@ -1 +1 @@
-2.0.4
+3.0.0

Review Comment:
   Actually I have the same question here. I will give a try to check it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#discussion_r854740812


##########
dolphinscheduler-dao/src/main/resources/sql/soft_version:
##########
@@ -1 +1 @@
-2.0.4
+3.0.0

Review Comment:
   I'm not familiar about dev. If we change ```soft_version``` to ```dev```. Will upgrade sql script be executed or skiped?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104651258

   @zhuangchong @caishunfeng @zhongjiajie Guys. Do you have time to take a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104647430

   @EricGao888 Would you please add these configure steps to docs? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng merged pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104663012

   > > > +1
   > > 
   > > 
   > > @SbloodyS @caishunfeng Just curious, I think db initialization is a basic and vital operation. Not sure why this bug hasn't been detected by our CI. Should I open an issue to add a check for this in CI?
   > 
   > Currently cluster `start/stop/create/upgrade` steps test does not included in our CI. I'm working on it in #9474
   
   Looks cool! I believe it will help make the code more robust : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#discussion_r854750190


##########
dolphinscheduler-dao/src/main/resources/sql/soft_version:
##########
@@ -1 +1 @@
-2.0.4
+3.0.0

Review Comment:
   This is related to the upgrade script, which will judge the number of the version, so if it is dev, there may be problems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#discussion_r854739478


##########
dolphinscheduler-dao/src/main/resources/sql/soft_version:
##########
@@ -1 +1 @@
-2.0.4
+3.0.0

Review Comment:
   @zhongjiajie Sure I will fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104651446

   > @EricGao888 Would you please add these configure steps to docs? Thanks.
   
   @SbloodyS BTW, do u have any suggestions for the SQL duplicate key & index errors caused by 2.1.0_schema? Apparently we cannot simply delete it. https://github.com/apache/dolphinscheduler/issues/9598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104657738

   > +1
   
   @SbloodyS @caishunfeng  Just curious, I think db initialization is a basic and vital operation. Not sure why this bug hasn't been detected by our CI. Should I open an issue to add a check for this in CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9637: [Bug][DAO] Update db init script and soft_version (#9628)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9637:
URL: https://github.com/apache/dolphinscheduler/pull/9637#issuecomment-1104362558

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9637)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9637&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9637&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9637&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org