You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by jburwell <gi...@git.apache.org> on 2016/11/17 03:02:54 UTC

[GitHub] cloudstack pull request #1545: CLOUDSTACK-8715: Add channel to Instances for...

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r88378111
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ---
    @@ -252,6 +253,8 @@
         protected String _rngPath = "/dev/random";
         protected int _rngRatePeriod = 1000;
         protected int _rngRateBytes = 2048;
    +    protected File _qemuSocketsPath;
    --- End diff --
    
    Why is this attribute declared `protected` rather than `private`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---