You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/06/02 20:13:19 UTC

Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs
-----

  include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 
  src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 
  src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 
  src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 
  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe 
  src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
  src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c 
  src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
  src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c 
  src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 
  src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 
  src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 
  src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 


Diff: https://reviews.apache.org/r/59766/diff/1/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review176942
-----------------------------------------------------------



Have you considered implementing this change outside of the allocator? It seems unfortunate that we keep pushing more problem-specific workarounds into the allocator which both complicates the `HierarchicalAllocator` and makes implementing custom allocators harder.

It seems to me that a filtering policy like this one (and e.g., also the work done here for GPUs), could be done just as well e.g., with `Filters`, i.e., for not region-aware frameworks a master could automatically inject `Filters` for all affected agents (this would require some adjustments to the effects of `revive` calls). Alternatively, one could imagine augmenting the allocator interface to allow injecting filtering policies (e.g., by passing a collection of callbacks).

- Benjamin Bannier


On June 5, 2017, 8:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 
>   src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 
>   src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 
>   src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 
>   src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
>   src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
>   src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c 
>   src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
>   src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c 
>   src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 
>   src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 
>   src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 
>   src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review177201
-----------------------------------------------------------



Bad patch!

Reviews applied: [59766, 59764, 59763, 59762, 59761, 59760, 59759]

Failed command: python support/apply-reviews.py -n -r 59766

Error:
error: patch failed: src/tests/master_allocator_tests.cpp:1424
error: src/tests/master_allocator_tests.cpp: patch does not apply

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/69/console

- Mesos Reviewbot Windows


On June 7, 2017, 6:14 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
>   src/master/allocator/mesos/allocator.hpp 5773d4182dc79405b872cb665a6ee734c82a3875 
>   src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
>   src/master/allocator/mesos/hierarchical.cpp 73d0b42433a1ff3e853e851b8191864b4e233666 
>   src/master/master.cpp 3c6925dc6055fb7cec12ec03bc557ad462863c58 
>   src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
>   src/tests/master_allocator_tests.cpp a301c16fa52cd024dfc8f5f2fdc226810333ffb8 
>   src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
>   src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
>   src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f 
>   src/tests/resource_offers_tests.cpp c2bbf834c1d46079af492887b9dd40e57f3f2ac7 
>   src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Vinod Kone <vi...@gmail.com>.

> On July 11, 2017, 12:08 a.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp
> > Lines 7406 (patched)
> > <https://reviews.apache.org/r/59766/diff/5/?file=1772912#file1772912line7406>
> >
> >     can you check that offer contains the domain?

i see that this happens in the next review. nm.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review180144
-----------------------------------------------------------


On July 10, 2017, 5:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 5:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 9d116c68fe7225178bba85414cb88d97fa0dbed5 
>   src/master/allocator/mesos/allocator.hpp 725ec7c3348b3f5c66bb6530983ee212480c5974 
>   src/master/allocator/mesos/hierarchical.hpp 81d1b964800ef69e25bc874dbadcdfcfd47392b2 
>   src/master/allocator/mesos/hierarchical.cpp fad9330dc371728e72eb2af808e993c4c97543af 
>   src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
>   src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
>   src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
>   src/tests/master_allocator_tests.cpp f83ca66e64fe6d2d10d104ff24f31afd84c50a3a 
>   src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
>   src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb 
>   src/tests/resource_offers_tests.cpp 427a6520034a537caf748a126001d131e196fedd 
>   src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review180144
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.hpp
Lines 527-528 (original), 533 (patched)
<https://reviews.apache.org/r/59766/#comment255162>

    bad rebase?



src/master/allocator/mesos/hierarchical.hpp
Lines 536 (patched)
<https://reviews.apache.org/r/59766/#comment255163>

    s/slave/agent/



src/master/allocator/mesos/hierarchical.cpp
Lines 2389 (patched)
<https://reviews.apache.org/r/59766/#comment255164>

    s/slave/agent/



src/tests/master_tests.cpp
Lines 7406 (patched)
<https://reviews.apache.org/r/59766/#comment255166>

    can you check that offer contains the domain?


- Vinod Kone


On July 10, 2017, 5:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 5:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 9d116c68fe7225178bba85414cb88d97fa0dbed5 
>   src/master/allocator/mesos/allocator.hpp 725ec7c3348b3f5c66bb6530983ee212480c5974 
>   src/master/allocator/mesos/hierarchical.hpp 81d1b964800ef69e25bc874dbadcdfcfd47392b2 
>   src/master/allocator/mesos/hierarchical.cpp fad9330dc371728e72eb2af808e993c4c97543af 
>   src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
>   src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
>   src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
>   src/tests/master_allocator_tests.cpp f83ca66e64fe6d2d10d104ff24f31afd84c50a3a 
>   src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
>   src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb 
>   src/tests/resource_offers_tests.cpp 427a6520034a537caf748a126001d131e196fedd 
>   src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

(Updated July 11, 2017, 5:18 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comments.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 9d116c68fe7225178bba85414cb88d97fa0dbed5 
  src/master/allocator/mesos/allocator.hpp 725ec7c3348b3f5c66bb6530983ee212480c5974 
  src/master/allocator/mesos/hierarchical.hpp 81d1b964800ef69e25bc874dbadcdfcfd47392b2 
  src/master/allocator/mesos/hierarchical.cpp fad9330dc371728e72eb2af808e993c4c97543af 
  src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
  src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
  src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
  src/tests/master_allocator_tests.cpp f83ca66e64fe6d2d10d104ff24f31afd84c50a3a 
  src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a 
  src/tests/master_tests.cpp 9cfa510f1e5742b47a44cb640a0d6ba85a2880ae 
  src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb 
  src/tests/resource_offers_tests.cpp 427a6520034a537caf748a126001d131e196fedd 
  src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 


Diff: https://reviews.apache.org/r/59766/diff/6/

Changes: https://reviews.apache.org/r/59766/diff/5-6/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

(Updated July 10, 2017, 5:26 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase, added comment.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 9d116c68fe7225178bba85414cb88d97fa0dbed5 
  src/master/allocator/mesos/allocator.hpp 725ec7c3348b3f5c66bb6530983ee212480c5974 
  src/master/allocator/mesos/hierarchical.hpp 81d1b964800ef69e25bc874dbadcdfcfd47392b2 
  src/master/allocator/mesos/hierarchical.cpp fad9330dc371728e72eb2af808e993c4c97543af 
  src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
  src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
  src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
  src/tests/master_allocator_tests.cpp f83ca66e64fe6d2d10d104ff24f31afd84c50a3a 
  src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a 
  src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
  src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb 
  src/tests/resource_offers_tests.cpp 427a6520034a537caf748a126001d131e196fedd 
  src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 


Diff: https://reviews.apache.org/r/59766/diff/5/

Changes: https://reviews.apache.org/r/59766/diff/4-5/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

(Updated July 5, 2017, 10:32 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
  src/master/allocator/mesos/allocator.hpp 2e780c92d5c5132abff32f1ce051c3bab2947f37 
  src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
  src/master/allocator/mesos/hierarchical.cpp eb01d8e6b1108866ebc049f9f4a46157823a3541 
  src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56 
  src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
  src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
  src/tests/master_allocator_tests.cpp f83ca66e64fe6d2d10d104ff24f31afd84c50a3a 
  src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a 
  src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
  src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb 
  src/tests/resource_offers_tests.cpp 427a6520034a537caf748a126001d131e196fedd 
  src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 


Diff: https://reviews.apache.org/r/59766/diff/4/

Changes: https://reviews.apache.org/r/59766/diff/3-4/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

(Updated June 7, 2017, 6:14 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
  src/master/allocator/mesos/allocator.hpp 5773d4182dc79405b872cb665a6ee734c82a3875 
  src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
  src/master/allocator/mesos/hierarchical.cpp 73d0b42433a1ff3e853e851b8191864b4e233666 
  src/master/master.cpp 3c6925dc6055fb7cec12ec03bc557ad462863c58 
  src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
  src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
  src/tests/master_allocator_tests.cpp a301c16fa52cd024dfc8f5f2fdc226810333ffb8 
  src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
  src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f 
  src/tests/resource_offers_tests.cpp c2bbf834c1d46079af492887b9dd40e57f3f2ac7 
  src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c 


Diff: https://reviews.apache.org/r/59766/diff/3/

Changes: https://reviews.apache.org/r/59766/diff/2-3/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review176939
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59759, 59760, 59761, 59762, 59763, 59764, 59765, 59766]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 5, 2017, 6:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 6:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 
>   src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 
>   src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 
>   src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 
>   src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
>   src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
>   src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c 
>   src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
>   src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c 
>   src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 
>   src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 
>   src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 
>   src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/
-----------------------------------------------------------

(Updated June 5, 2017, 6:30 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Improve tests.


Bugs: MESOS-7614
    https://issues.apache.org/jira/browse/MESOS-7614


Repository: mesos


Description
-------

Changed allocator to offer remote resources to region-aware frameworks.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 
  src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 
  src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 
  src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 
  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe 
  src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
  src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c 
  src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
  src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c 
  src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 
  src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 
  src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 
  src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 


Diff: https://reviews.apache.org/r/59766/diff/2/

Changes: https://reviews.apache.org/r/59766/diff/1-2/


Testing
-------

`make check`.


Thanks,

Neil Conway


Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59766/#review176841
-----------------------------------------------------------



Bad patch!

Reviews applied: [59766, 59765, 59764, 59763, 59762, 59761, 59760, 59759]

Failed command: python support/apply-reviews.py -n -r 59760

Error:
error: patch failed: include/mesos/mesos.proto:343
error: include/mesos/mesos.proto: patch does not apply
error: patch failed: include/mesos/v1/mesos.proto:343
error: include/mesos/v1/mesos.proto: patch does not apply

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/console

- Mesos Reviewbot Windows


On June 2, 2017, 8:13 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59766/
> -----------------------------------------------------------
> 
> (Updated June 2, 2017, 8:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7614
>     https://issues.apache.org/jira/browse/MESOS-7614
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed allocator to offer remote resources to region-aware frameworks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 
>   src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 
>   src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 
>   src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 
>   src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
>   src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
>   src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c 
>   src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
>   src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c 
>   src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 
>   src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 
>   src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 
>   src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 
> 
> 
> Diff: https://reviews.apache.org/r/59766/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>