You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 01:10:26 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #7361: [migration] Using existing_type rather than type_

john-bodley opened a new pull request #7361: [migration] Using existing_type rather than type_
URL: https://github.com/apache/incubator-superset/pull/7361
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR uses the Alembic [`existing_type`](https://alembic.sqlalchemy.org/en/latest/ops.html?highlight=insert#alembic.operations.Operations.alter_column) as opposed to `type_` as the preferred approach for altering a column where the type is unchanged.
   
   ### TEST PLAN
   
   CI. 
   
   ### REVIEWERS
   
   to: @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org