You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 19:45:52 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8305: ARROW-9782: [C++][Dataset] More configurable Dataset writing

jorisvandenbossche commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r499831141



##########
File path: python/pyarrow/dataset.py
##########
@@ -694,22 +697,23 @@ def _ensure_write_partitioning(scheme):
     return scheme
 
 
-def write_dataset(data, base_dir, format=None, partitioning=None, schema=None,
-                  filesystem=None, use_threads=True):
+def write_dataset(data, base_dir, basename_template, format=None,

Review comment:
       Should we provide a default template here? 
   Can eg the format object have a property with the default name to use? (or get the extension from there and use that in a default?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org