[GitHub] [incubator-druid] clintropolis opened a new pull request #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs

[GitBox <gi...@apache.org>]

clintropolis opened a new pull request #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731
 
 
   `AggregatorFactory.finalizeComputation` is nullable with nullable input, but some aggregators do not check for this and can explode if the input is null. I _think_ I got them all in this PR.
   
   I did not add unit tests to ensure all of these methods are ok, but tested by hand and the scenario should easily be able to be replicated by using any of the aggs fixed in this PR in a timeseries query with `grandTotal` enabled and using an out of range interval (so no actual segment data for input) which produces a `java.lang.NullPointerException`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org