[jira] [Comment Edited] (CALCITE-978) Make ReduceExpressionsRule extensible to transform false filter in schema-on-read case

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009410#comment-15009410 ] 

Julian Hyde edited comment on CALCITE-978 at 11/19/15 10:29 PM:
----------------------------------------------------------------

[~jaltekruse], could you please submit a PR to Calcite after rebasing? There might be some conflicts with CALCITE-909, which made changes to ReduceExpressionRules in Calcite 1.5.0. 




was (Author: jni):
[~jaltekruse], could you please submit a PR to Calcite after rebasing? There might be some conflicts with Calcite-909, which made changes to ReduceExpressionRules in Calcite 1.5.0. 



> Make ReduceExpressionsRule extensible to transform false filter in schema-on-read case 
> ---------------------------------------------------------------------------------------
>
>                 Key: CALCITE-978
>                 URL: https://issues.apache.org/jira/browse/CALCITE-978
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jinfeng Ni
>            Assignee: Julian Hyde
>              Labels: drill
>
> This comes from a commit in Drill's forked Calcite (https://github.com/dremio/calcite/commit/a29f007f4f4017368b6f41bf8c3aba4490a1cee8).
> ReduceExpressionRule will transform a false filter into VALUES with empty input. This only works in the case of schema-aware scenario.  In schema-on-read scenario like Drill, VALUES would not provide the schema type at the planning time; schema has to be propagate during execution time.
> We should allow ReduceExpressionRule extensible so that different behavior would be allowed to handle false filter in both schema-aware case and schema-on-read case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)