You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/07 23:51:06 UTC
[GitHub] [airflow] kaxil opened a new pull request #12901: Fix Multiple Migrations Heads
kaxil opened a new pull request #12901:
URL: https://github.com/apache/airflow/pull/12901
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12901:
URL: https://github.com/apache/airflow/pull/12901#issuecomment-740253233
Diff: https://www.diffchecker.com/mPJvy15M
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12901:
URL: https://github.com/apache/airflow/pull/12901#issuecomment-740256340
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12901:
URL: https://github.com/apache/airflow/pull/12901#issuecomment-740252655
Tested it before and after locally with breeze
```
================================================================================================================== short test summary info ===================================================================================================================
FAILED tests/utils/test_db.py::TestDb::test_only_single_head_revision_in_migrations - alembic.util.exc.CommandError: The script directory has multiple heads (due to branching).Please use get_heads(), or merge the branches using alembic merge.
=============================================================================================================== 1 failed, 1 warning in 11.27s ================================================================================================================
root@125bca82d58b:/opt/airflow# pytest tests/utils/test_db.py::TestDb::test_only_single_head_revision_in_migrations
==================================================================================================================== test session starts =====================================================================================================================
platform linux -- Python 3.6.12, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: forked-1.3.0, timeouts-1.2.1, cov-2.10.1, celery-4.4.7, flaky-3.7.0, xdist-2.1.0, instafail-0.4.2, requests-mock-1.8.0, rerunfailures-9.1.1
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 1 item
tests/utils/test_db.py::TestDb::test_only_single_head_revision_in_migrations PASSED [100%]
===================================================================================================================== 1 passed in 2.42s ======================================================================================================================
root@125bca82d58b:/opt/airflow#
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #12901:
URL: https://github.com/apache/airflow/pull/12901#issuecomment-740252305
Looks good @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12901:
URL: https://github.com/apache/airflow/pull/12901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #12901: Fix Multiple Migrations Heads
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #12901:
URL: https://github.com/apache/airflow/pull/12901#issuecomment-740253233
Migrations Diff: https://www.diffchecker.com/mPJvy15M
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org