You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/09/03 19:00:01 UTC
Re: Review Request 68610: Updated libjvm search logic for newer
openjdk versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68610/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 3 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Added fix for macos as well.
Summary (updated)
-----------------
Updated libjvm search logic for newer openjdk versions.
Bugs: MESOS-8921
https://issues.apache.org/jira/browse/MESOS-8921
Repository: mesos
Description (updated)
-------
Updated libjvm search logic for newer openjdk versions.
Diffs (updated)
-----
configure.ac d84581823708cdece68d52bdc023e01d72645bf8
Diff: https://reviews.apache.org/r/68610/diff/2/
Changes: https://reviews.apache.org/r/68610/diff/1-2/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 68610: Updated libjvm search logic for newer
openjdk versions.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68610/#review208277
-----------------------------------------------------------
Ship it!
Terriffic, I am really glad this got solved - thanks so much Kapil!
Please add something to the testing done section; you can add my testing there as well;
```
Tested on macOS 10.14 with jdk10 installed via homebrew.
```
- Till Toenshoff
On Sept. 3, 2018, 7 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68610/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 7 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-8921
> https://issues.apache.org/jira/browse/MESOS-8921
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated libjvm search logic for newer openjdk versions.
>
>
> Diffs
> -----
>
> configure.ac d84581823708cdece68d52bdc023e01d72645bf8
>
>
> Diff: https://reviews.apache.org/r/68610/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>