You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/31 22:36:02 UTC
[GitHub] [lucenenet] rclabo opened a new pull request, #735: Removed .NET Core 3.1 support.
rclabo opened a new pull request, #735:
URL: https://github.com/apache/lucenenet/pull/735
.NET Core 3.1 will reach end of live in 45 days on Dec 13, 2022 so it was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] rclabo commented on pull request #735: Removed .NET Core 3.1 tests and lucene-cli support for it.
Posted by GitBox <gi...@apache.org>.
rclabo commented on PR #735:
URL: https://github.com/apache/lucenenet/pull/735#issuecomment-1298890833
Wow! @NightOwl888 you have more commits on this PR then I do. Looks like I only got the party started. I appreciate you buddy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on a diff in pull request #735: Removed .NET Core 3.1 support.
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on code in PR #735:
URL: https://github.com/apache/lucenenet/pull/735#discussion_r1009934152
##########
TestTargetFramework.props:
##########
@@ -28,14 +28,13 @@
this setting only affects the test projects. -->
<!--<TargetFramework>net461</TargetFramework>-->
<!--<TargetFramework>net48</TargetFramework>-->
- <!--<TargetFramework>netcoreapp3.1</TargetFramework>-->
<TargetFramework>net5.0</TargetFramework>
<!--<TargetFramework>net6.0</TargetFramework>-->
<!-- Allow the build script to pass in the test frameworks to build for.
This overrides the above TargetFramework setting.
LUCENENET TODO: Due to a parsing bug, we cannot pass a string with a ; to dotnet msbuild, so passing true as a workaround -->
- <TargetFrameworks Condition=" '$(TestFrameworks)' == 'true' ">net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
+ <TargetFrameworks Condition=" '$(TestFrameworks)' == 'true' ">net6.0;net5.0;</TargetFrameworks>
Review Comment:
There is an extra `;` at the end here that can be removed. When this value is concatenated with the values below, we end up with an empty array element `;;`.
##########
src/dotnet/tools/lucene-cli/docs/index.md:
##########
@@ -1,10 +1,10 @@
-# Lucene.NET command line interface (CLI) tools
+# Lucene.NET command line interface (CLI) tools
The Lucene.NET command line interface (CLI) is a new cross-platform toolchain with utilities for maintaining Lucene.NET and demos for learning basic Lucene.NET functionality.
## Prerequisites
-- [.NET Core 3.1 Runtime or Higher](https://dotnet.microsoft.com/en-us/download/dotnet)
+- [.NET Core 5.0 Runtime or Higher](https://dotnet.microsoft.com/en-us/download/dotnet)
Review Comment:
Technically, it is `.NET 5.0 Runtime or Higher`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #735: Removed .NET Core 3.1 tests and lucene-cli support for it.
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #735:
URL: https://github.com/apache/lucenenet/pull/735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #735: Removed .NET Core 3.1 tests and lucene-cli support for it.
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on PR #735:
URL: https://github.com/apache/lucenenet/pull/735#issuecomment-1299140114
Yea, it took some work to solve some issues:
1. Pre-pack the lucene-cli tool prior to the test, which is much faster than having the test runner do it.
2. Set the Azure DevOps environment variable so the tests know where to look for the `.nupkg` file.
3. Bump the `Microsoft.Extensions.Configuration` version from 3.1.0 to 3.1.6. Now the tests work both for lucene-cli and for the `net461` target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org