You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/04 20:28:59 UTC
[GitHub] [spark] baohe-zhang opened a new pull request #31743: [SPARK-32924] Make duration column in master UI sorted in the correct order
baohe-zhang opened a new pull request #31743:
URL: https://github.com/apache/spark/pull/31743
### What changes were proposed in this pull request?
Make the "duration" column in standalone mode master UI sorted by numeric duration, hence the column can be sorted by the correct order.
Before changes:
After changes:
### Why are the changes needed?
Fix a UI bug to make the sorting consistent across different pages.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Ran several apps with different durations and verified the duration column on the master page can be sorted correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791031544
cc @gengliangwang , too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] baohe-zhang commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
baohe-zhang commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791109387
@dongjoon-hyun Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31743:
URL: https://github.com/apache/spark/pull/31743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791098771
Thank you, @baohe-zhang . I assigned SPARK-32924 to you.
Thank you for review, @gengliangwang !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791031167
Merged to master/3.1/3.0/2.4.
cc @viirya since he is the release manager for Apache Spark 2.4.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791039047
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135771/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] baohe-zhang commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
baohe-zhang commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791032807
@dongjoon-hyun My jira user id is `Baohe Zhang`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-790953602
**[Test build #135771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135771/testReport)** for PR 31743 at commit [`55a360d`](https://github.com/apache/spark/commit/55a360d31af21da85b380e2f05380a57b881bb7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] baohe-zhang edited a comment on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
baohe-zhang edited a comment on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791032807
@dongjoon-hyun My jira user id is `Baohe Zhang`
I left a comment in the Jira ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-790973423
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40353/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-790973423
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40353/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791034779
**[Test build #135771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135771/testReport)** for PR 31743 at commit [`55a360d`](https://github.com/apache/spark/commit/55a360d31af21da85b380e2f05380a57b881bb7d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791031401
BTW, what is your JIRA id, @baohe-zhang ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-791039047
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135771/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31743: [SPARK-32924][WEBUI] Make duration column in master UI sorted in the correct order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31743:
URL: https://github.com/apache/spark/pull/31743#issuecomment-790953602
**[Test build #135771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135771/testReport)** for PR 31743 at commit [`55a360d`](https://github.com/apache/spark/commit/55a360d31af21da85b380e2f05380a57b881bb7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org