You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/06 06:16:03 UTC

[GitHub] [incubator-yunikorn-core] steinsgateted edited a comment on pull request #380: [Yunikorn 1093] Track rejected applications

steinsgateted edited a comment on pull request #380:
URL: https://github.com/apache/incubator-yunikorn-core/pull/380#issuecomment-1059901365


   If the app is rejected, display this message in /ws/v1/apps :
   ```
   [
     {
       "applicationID": "application-sleep-0003",
       "usedResource": "[]",
       "maxUsedResource": "[]",
       "partition": "default",
       "queueName": "",
       "submissionTime": 1646541113515060500,
       "finishedTime": 1646541113515105300,
       "allocations": [],
       "applicationState": "Rejected",
       "user": "nobody",
       "rejectionMessage": "failed to place application application-sleep-0003: application rejected: no placment rule matched"
     }
   ]
   ```
   Because the rejected app was not added to the queue, there is no information in /ws/v1/partition/{partitioName}/queue/{queueName}/applications.
   
   In `pkg/scheduler/context.go` `handleRMUpdateApplicationEvent `func, if partition != nil , then save app to pc.rejectedApplications.
   
   Reuse finishedTime to record reject timestamp
   
   In `pkg/scheduler/objects/application_state.go`, add a rejected to expire state transition.
   
   In `pkg/scheduler/partition.go`, add a GetRejectedAppsByState func to find expired apps in rejected applications
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org