[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1813: ci: Fix build for nodejs binding on macos

["suyanhanx (via GitHub)" <gi...@apache.org>]

suyanhanx commented on code in PR #1813:
URL: https://github.com/apache/incubator-opendal/pull/1813#discussion_r1153979575


##########
bindings/nodejs/package.json:
##########
@@ -59,15 +59,12 @@
     "node": ">= 10"
   },
   "scripts": {
-    "artifacts": "napi artifacts",
-    "build": "napi build --platform --release --js generated.js && node ./scripts/header.js",
-    "build:debug": "napi build --platform --js generated.js && node ./scripts/header.js",
+    "build": "napi build --platform --target \"${NAPI_TARGET:-}\" --release --js generated.js && node ./scripts/header.js",
+    "build:debug": "napi build --platform --target \"${NAPI_TARGET:-}\" --js generated.js && node ./scripts/header.js",
     "docs": "typedoc",
     "format": "prettier --write .",
-    "prepublishOnly": "napi prepublish -t npm",

Review Comment:
   We should not delete this. This is useful for publishing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org