You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Kulp (JIRA)" <ji...@codehaus.org> on 2007/11/06 22:23:35 UTC
[jira] Created: (MSOURCES-26) source:jar ignoring remote-resources
source:jar ignoring remote-resources
------------------------------------
Key: MSOURCES-26
URL: http://jira.codehaus.org/browse/MSOURCES-26
Project: Maven 2.x Source Plugin
Issue Type: Bug
Affects Versions: 2.0.3
Reporter: Daniel Kulp
Priority: Critical
The source jar created does not include the resources generated from the remote-resources plugin. This works fine with 2.0.2, but not with 2.0.3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-26) source:jar ignoring
remote-resources
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112993 ]
Daniel Kulp commented on MSOURCES-26:
-------------------------------------
This is due to the change:
- if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
- {
- archiver.addDirectory( new File( r.getDirectory() ) );
- }
to:
+ if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
+ {
+ addDirectory( archiver, new File( r.getDirectory() ), new String[]{}, new String[]{} );
+ }
The "includes"is empty so nothing is included. Changing it to:
if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
{
addDirectory( archiver, new File( r.getDirectory() ), DEFAULT_INCLUDES, new String[0] );
}
works fine.
> source:jar ignoring remote-resources
> ------------------------------------
>
> Key: MSOURCES-26
> URL: http://jira.codehaus.org/browse/MSOURCES-26
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Priority: Critical
>
> The source jar created does not include the resources generated from the remote-resources plugin. This works fine with 2.0.2, but not with 2.0.3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSOURCES-26) source:jar ignoring
remote-resources
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112993 ]
Daniel Kulp edited comment on MSOURCES-26 at 11/6/07 4:13 PM:
--------------------------------------------------------------
This is due to the change:
{code}
- if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
- {
- archiver.addDirectory( new File( r.getDirectory() ) );
- }
{code}
to:
{code}
+ if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
+ {
+ addDirectory( archiver, new File( r.getDirectory() ), new String[]{}, new String[]{} );
+ }
{code}
The "includes"is empty so nothing is included. Changing it to:
{code}
if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
{
addDirectory( archiver, new File( r.getDirectory() ), DEFAULT_INCLUDES, new String[0] );
}
{code}
works fine.
was:
This is due to the change:
- if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
- {
- archiver.addDirectory( new File( r.getDirectory() ) );
- }
to:
+ if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
+ {
+ addDirectory( archiver, new File( r.getDirectory() ), new String[]{}, new String[]{} );
+ }
The "includes"is empty so nothing is included. Changing it to:
if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
{
addDirectory( archiver, new File( r.getDirectory() ), DEFAULT_INCLUDES, new String[0] );
}
works fine.
> source:jar ignoring remote-resources
> ------------------------------------
>
> Key: MSOURCES-26
> URL: http://jira.codehaus.org/browse/MSOURCES-26
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Priority: Critical
>
> The source jar created does not include the resources generated from the remote-resources plugin. This works fine with 2.0.2, but not with 2.0.3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MSOURCES-26) source:jar ignoring
remote-resources
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112993 ]
Daniel Kulp edited comment on MSOURCES-26 at 11/6/07 4:12 PM:
--------------------------------------------------------------
This is due to the change:
- if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
- {
- archiver.addDirectory( new File( r.getDirectory() ) );
- }
to:
+ if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
+ {
+ addDirectory( archiver, new File( r.getDirectory() ), new String[]{}, new String[]{} );
+ }
The "includes"is empty so nothing is included. Changing it to:
if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
{
addDirectory( archiver, new File( r.getDirectory() ), DEFAULT_INCLUDES, new String[0] );
}
works fine.
was:
This is due to the change:
- if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
- {
- archiver.addDirectory( new File( r.getDirectory() ) );
- }
to:
+ if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
+ {
+ addDirectory( archiver, new File( r.getDirectory() ), new String[]{}, new String[]{} );
+ }
The "includes"is empty so nothing is included. Changing it to:
if ( r.getDirectory().endsWith( "maven-shared-archive-resources" ) )
{
addDirectory( archiver, new File( r.getDirectory() ), DEFAULT_INCLUDES, new String[0] );
}
works fine.
> source:jar ignoring remote-resources
> ------------------------------------
>
> Key: MSOURCES-26
> URL: http://jira.codehaus.org/browse/MSOURCES-26
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Priority: Critical
>
> The source jar created does not include the resources generated from the remote-resources plugin. This works fine with 2.0.2, but not with 2.0.3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSOURCES-26) source:jar ignoring remote-resources
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSOURCES-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MSOURCES-26.
-----------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 2.0.4
Fixed, thanks!
> source:jar ignoring remote-resources
> ------------------------------------
>
> Key: MSOURCES-26
> URL: http://jira.codehaus.org/browse/MSOURCES-26
> Project: Maven 2.x Source Plugin
> Issue Type: Bug
> Affects Versions: 2.0.3
> Reporter: Daniel Kulp
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.0.4
>
>
> The source jar created does not include the resources generated from the remote-resources plugin. This works fine with 2.0.2, but not with 2.0.3.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira