You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vamossagar12 (via GitHub)" <gi...@apache.org> on 2023/10/23 02:21:53 UTC

[PR] KAFKA-15457: Add support for OffsetFetch version 9 in admin client [kafka]

vamossagar12 opened a new pull request, #14611:
URL: https://github.com/apache/kafka/pull/14611

   This PR adds support for OffsetFetch version 9 in the admin client. It mainly allows handling 2 new error codes `STALE_MEMBER_EPOCH` and `UNKNOWN_MEMBER_ID`  introduced as part of KIP-848.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15457: Add support for OffsetFetch version 9 in admin client [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #14611:
URL: https://github.com/apache/kafka/pull/14611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-15457: Add support for OffsetFetch version 9 in admin client [kafka]

Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on code in PR #14611:
URL: https://github.com/apache/kafka/pull/14611#discussion_r1368057590


##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java:
##########
@@ -54,6 +54,8 @@
  *   - {@link Errors#COORDINATOR_NOT_AVAILABLE}
  *   - {@link Errors#NOT_COORDINATOR}
  *   - {@link Errors#GROUP_AUTHORIZATION_FAILED}
+ *   - {@link Errors#UNKNOWN_MEMBER_ID}
+ *   - {@link Errors#STALE_MEMBER_EPOCH}

Review Comment:
   I have clubbed these 2 new errors under `Group or coordinator errors` although these really seem to be member specific errors. Is that ok or should I create a new category? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org