[GitHub] [hbase] saintstack commented on a change in pull request #646: HBASE-23055 Alter hbase:meta

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #646: HBASE-23055 Alter hbase:meta
URL: https://github.com/apache/hbase/pull/646#discussion_r326480749
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
 ##########
 @@ -663,9 +663,9 @@ public void run(PRESP resp) {
 
   @Override
   public CompletableFuture<Boolean> isTableEnabled(TableName tableName) {
-    if (TableName.isMetaTableName(tableName)) {
-      return CompletableFuture.completedFuture(true);
-    }
+    // TODO: This doesn't work if tablename is hbase:meta. Need to ask Master.
+    // Other problems with this implementation are that it presumes state is
+    // available in Master. Would be good to hide how state is kept.
 
 Review comment:
   s/Master/hbase:meta/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services