You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/10 22:32:02 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #5115: Refactor the
data source to include all information needed for query execution
codecov-io commented on issue #5115: Refactor the data source to include all information needed for query execution
URL: https://github.com/apache/incubator-pinot/pull/5115#issuecomment-597352875
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=h1) Report
> Merging [#5115](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/76f9c53b7417417c5fabceccaa124ba371a95417&el=desc) will **decrease** coverage by `12.22%`.
> The diff coverage is `68.28%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5115 +/- ##
=============================================
- Coverage 56.53% 44.31% -12.23%
=============================================
Files 1049 1051 +2
Lines 54096 54120 +24
Branches 8074 8068 -6
=============================================
- Hits 30581 23981 -6600
- Misses 21072 28069 +6997
+ Partials 2443 2070 -373
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/pinot/common/config/ColumnPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0NvbHVtblBhcnRpdGlvbkNvbmZpZy5qYXZh) | `75.00% <ø> (+20.45%)` | `0.00 <0.00> (ø)` | |
| [...he/pinot/common/config/SegmentPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1NlZ21lbnRQYXJ0aXRpb25Db25maWcuamF2YQ==) | `40.00% <ø> (-24.29%)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `52.85% <0.00%> (+2.93%)` | `0.00 <0.00> (ø)` | |
| [...ealtime/impl/dictionary/BaseMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `100.00% <ø> (+50.00%)` | `0.00 <0.00> (ø)` | |
| [...che/pinot/core/util/FixedIntArrayOffHeapIdMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0ZpeGVkSW50QXJyYXlPZmZIZWFwSWRNYXAuamF2YQ==) | `0.00% <ø> (-59.10%)` | `0.00 <0.00> (ø)` | |
| [...erter/stats/RealtimeNoDictionaryColStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVOb0RpY3Rpb25hcnlDb2xTdGF0aXN0aWNzLmphdmE=) | `55.00% <46.15%> (+55.00%)` | `0.00 <0.00> (ø)` | |
| [...time/converter/stats/RealtimeColumnStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVDb2x1bW5TdGF0aXN0aWNzLmphdmE=) | `47.54% <52.00%> (+47.54%)` | `0.00 <0.00> (ø)` | |
| [...not/core/startree/v2/store/StarTreeDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZURhdGFTb3VyY2UuamF2YQ==) | `56.25% <56.25%> (ø)` | `0.00 <0.00> (?)` | |
| [...inot/core/realtime/impl/RealtimeSegmentConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1JlYWx0aW1lU2VnbWVudENvbmZpZy5qYXZh) | `90.47% <58.33%> (-4.27%)` | `0.00 <0.00> (ø)` | |
| ... and [737 more](https://codecov.io/gh/apache/incubator-pinot/pull/5115/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=footer). Last update [76f9c53...04db461](https://codecov.io/gh/apache/incubator-pinot/pull/5115?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org