You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "tsreaper (via GitHub)" <gi...@apache.org> on 2026/09/16 06:08:41 UTC

[PR] [core] Add option to disable overflow exception in sum agg [paimon]

tsreaper opened a new pull request, #9874:
URL: https://github.com/apache/paimon/pull/9874

   ### Purpose
   
   #7992 adds overflow detection in sum agg. If the result overflows, it will throw an exception.
   
   However, some users don't care about overflows. This change will break their jobs without a way to recover.
   
   This PR adds an option to disable the overflow exception.
   
   ### Tests
   
   * `FieldAggregatorTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Add option to disable overflow exception in sum/product agg [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #9874:
URL: https://github.com/apache/paimon/pull/9874


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Add option to disable overflow exception in sum agg [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #9874:
URL: https://github.com/apache/paimon/pull/9874#discussion_r4023591019


##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -3366,6 +3366,13 @@ public boolean fieldAggIgnoreRetract(String fieldName) {
                         .defaultValue(false));
     }
 
+    public boolean fieldSumAggFailOnOverflow(String fieldName) {
+        return options.get(
+                key(FIELDS_PREFIX + "." + fieldName + ".sum.fail-on-overflow")
+                        .booleanType()
+                        .defaultValue(true));

Review Comment:
   Maybe default value should be false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org