You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/20 21:47:36 UTC
[GitHub] [cloudstack] benj-n opened a new pull request, #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
benj-n opened a new pull request, #7007:
URL: https://github.com/apache/cloudstack/pull/7007
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
Fixes: #7000
It makes prometheus integration returns the same value ("0") when a capacity is explicitly "Disabled" or non-existent.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Set a host in maintenance.
Restart the cloudstack-management service.
Capacities are set to Disabled in table "op_host_capacity".
```
MariaDB [cloud]> SELECT id,host_id,used_capacity,reserved_capacity,total_capacity,capacity_type,capacity_state FROM op_host_capacity WHERE `host_id`=1;
+----+---------+---------------+-------------------+----------------+---------------+----------------+
| id | host_id | used_capacity | reserved_capacity | total_capacity | capacity_type | capacity_state |
+----+---------+---------------+-------------------+----------------+---------------+----------------+
| 11 | 1 | 196640 | 0 | 105419636736 | 3 | Enabled |
| 18 | 1 | 0 | 0 | 2 | 90 | Disabled |
| 19 | 1 | 0 | 0 | 3048968192 | 0 | Disabled |
| 20 | 1 | 0 | 0 | 4394 | 1 | Disabled |
+----+---------+---------------+-------------------+----------------+---------------+----------------+
4 rows in set (0.00 sec)
```
For the three disabled capacity types, Prometheus exporter returns a total capacity value of "0".
```
~# curl -s localhost:9595/metrics | grep node01 | grep "vms_cores_total\|cpu_usage_mhz\|memory_usage_mibs" | grep 'filter="total"'
cloudstack_host_cpu_usage_mhz_total{zone="testZone1",hostname="node01",ip="redacted",overprovisioningfactor="1.0",filter="total",tags=""} 0.00
cloudstack_host_memory_usage_mibs_total{zone="testZone1",hostname="node01",ip="redacted",overprovisioningfactor="1.0",filter="total",dedicated="0",tags=""} 0.00
cloudstack_host_vms_cores_total{zone="testZone1",hostname="node01",ip="redacted",filter="total",dedicated="0",tags=""} 0
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on a diff in pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
soreana commented on code in PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#discussion_r1057565725
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -177,7 +178,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
metricsList.add(new ItemHostVM(zoneName, zoneUuid, host.getName(), host.getUuid(), host.getPrivateIpAddress(), vmDao.listByHostId(host.getId()).size()));
final CapacityVO coreCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU_CORE);
- if (coreCapacity != null) {
+ if (coreCapacity != null && coreCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n And here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1360412404
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7007)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7007&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7007&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7007&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7007&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7007&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7007&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7007&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7007&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on a diff in pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
soreana commented on code in PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#discussion_r1057565506
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -166,7 +167,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
final String memoryFactor = String.valueOf(CapacityManager.MemOverprovisioningFactor.valueIn(host.getClusterId()));
final CapacityVO memCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_MEMORY);
- if (memCapacity != null) {
+ if (memCapacity != null && memCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n And also here.
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -177,7 +178,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
metricsList.add(new ItemHostVM(zoneName, zoneUuid, host.getName(), host.getUuid(), host.getPrivateIpAddress(), vmDao.listByHostId(host.getId()).size()));
final CapacityVO coreCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU_CORE);
- if (coreCapacity != null) {
+ if (coreCapacity != null && coreCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n And here as well.
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -156,7 +157,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
final String cpuFactor = String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
final CapacityVO cpuCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
- if (cpuCapacity != null) {
+ if (cpuCapacity != null && cpuCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n We use 0 value to check if the host is in the maintenance. If you only show enabled hosts entries, is is not possible to track hosts in maintenance. I prefer to modify these if statement in a way that it shows zero for hosts in maintenance mode and the correct value for the reset.
Or if you really want to exclude disabled hosts entries from prometheus exporter, can you please add a global setting to control that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on a diff in pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
soreana commented on code in PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#discussion_r1058404412
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -156,7 +157,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
final String cpuFactor = String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
final CapacityVO cpuCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
- if (cpuCapacity != null) {
+ if (cpuCapacity != null && cpuCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n I missed an else statement. That looks good. Ignore my comment. :-)
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -166,7 +167,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
final String memoryFactor = String.valueOf(CapacityManager.MemOverprovisioningFactor.valueIn(host.getClusterId()));
final CapacityVO memCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_MEMORY);
- if (memCapacity != null) {
+ if (memCapacity != null && memCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n And also here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on a diff in pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
soreana commented on code in PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#discussion_r1057564129
##########
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:
##########
@@ -156,7 +157,7 @@ private void addHostMetrics(final List<Item> metricsList, final long dcId, final
final String cpuFactor = String.valueOf(CapacityManager.CpuOverprovisioningFactor.valueIn(host.getClusterId()));
final CapacityVO cpuCapacity = capacityDao.findByHostIdType(host.getId(), Capacity.CAPACITY_TYPE_CPU);
- if (cpuCapacity != null) {
+ if (cpuCapacity != null && cpuCapacity.getCapacityState() == CapacityState.Enabled) {
Review Comment:
@benj-n We use a 0 value to check if the host is in maintenance. If you only show enabled host entries, it is not possible to track hosts in maintenance. I prefer to modify these if statements in a way that shows zero for hosts in maintenance mode and the correct value for the reset.
Or, if you want to exclude disabled host entries from Prometheus exporter, can you please add a global setting to control that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361061707
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1366786423
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361049238
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1360367940
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1366713558
@DaanHoogland It LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361000542
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361062367
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1362129969
<b>Trillian test result (tid-5598)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43051 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7007-t5598-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 504.49 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 606.34 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361001530
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361065358
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7007](https://codecov.io/gh/apache/cloudstack/pull/7007?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f130d44) into [main](https://codecov.io/gh/apache/cloudstack/commit/34e4376c16454b5c0026988ec170e055c4649450?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34e4376) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #7007 +/- ##
=========================================
Coverage 11.29% 11.29%
- Complexity 7308 7310 +2
=========================================
Files 2494 2494
Lines 246877 246877
Branches 38577 38577
=========================================
+ Hits 27884 27888 +4
+ Misses 215400 215395 -5
- Partials 3593 3594 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/cloudstack/metrics/PrometheusExporterImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7007/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMvcHJvbWV0aGV1cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9tZXRyaWNzL1Byb21ldGhldXNFeHBvcnRlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7007/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7007:
URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1361065388
@soreana can you review/test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org