You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/09 23:20:48 UTC
[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5760: [PatternLang] Add ShapePattern and DataTypePattern
mbrookhart opened a new pull request #5760:
URL: https://github.com/apache/incubator-tvm/pull/5760
cc @comaniac @lixiaoquan @masahi
Add Shape and Dtype patterns in response to https://discuss.tvm.ai/t/pattenlang-how-to-match-op-according-to-element-type-of-input-and-output/6846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi commented on pull request #5760: [PatternLang] Add ShapePattern and DataTypePattern
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #5760:
URL: https://github.com/apache/incubator-tvm/pull/5760#issuecomment-642693067
Thanks @mbrookhart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mbrookhart commented on pull request #5760: [PatternLang] Add ShapePattern and DataTypePattern
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #5760:
URL: https://github.com/apache/incubator-tvm/pull/5760#issuecomment-642092107
@jroesch The problem comes in handling the matcher in the backend. Since Types belong to a lower level than the pattern language, we can't really embed something like a Wildcard into a Type, which means we'd have to create special rules for special values if we only wanted to match dtype or shape.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] masahi merged pull request #5760: [PatternLang] Add ShapePattern and DataTypePattern
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5760:
URL: https://github.com/apache/incubator-tvm/pull/5760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #5760: [PatternLang] Add ShapePattern and DataTypePattern
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #5760:
URL: https://github.com/apache/incubator-tvm/pull/5760#issuecomment-641666196
One question is why can't we desguar the dtype and shape patterns into type patterns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org