[GitHub] [arrow-rs] alamb commented on a change in pull request #1506: Implement `size_hint` and `ExactSizedIterator` for `DecimalArray`

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1506:
URL: https://github.com/apache/arrow-rs/pull/1506#discussion_r837800300



##########
File path: arrow/src/array/array_binary.rs
##########
@@ -1020,8 +1020,17 @@ impl<'a> std::iter::Iterator for DecimalIter<'a> {
             }
         }
     }
+
+    #[inline]
+    fn size_hint(&self) -> (usize, Option<usize>) {
+        let remain = self.array.len() - self.current;
+        (remain, Some(remain))
+    }
 }
 
+/// iterator has have known size.
+impl<'a> std::iter::ExactSizeIterator for DecimalIter<'a> {}

Review comment:
       🤔  that is a good idea. I can certainly move it there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org