You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2015/04/01 12:45:34 UTC
svn commit: r1670610 -
/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
Author: violetagg
Date: Wed Apr 1 10:45:33 2015
New Revision: 1670610
URL: http://svn.apache.org/r1670610
Log:
Removed debug messages as they do not give any valuable information and floods the log files with empty rows. Patch provided by Polina Genova.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1670610&r1=1670609&r2=1670610&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Apr 1 10:45:33 2015
@@ -943,9 +943,6 @@ public class Digester extends DefaultHan
// Recover the body text from the surrounding element
bodyText = bodyTexts.pop();
- if (debug) {
- log.debug(" Popping body text '" + bodyText.toString() + "'");
- }
// Fire "end" events for all relevant rules in reverse order
if (rules != null) {
@@ -1148,9 +1145,6 @@ public class Digester extends DefaultHan
// Save the body text accumulated for our surrounding element
bodyTexts.push(bodyText);
- if (debug) {
- log.debug(" Pushing body text '" + bodyText.toString() + "'");
- }
bodyText = new StringBuilder();
// the actual element name is either in localName or qName, depending
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1670610 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
Posted by Mark Thomas <ma...@apache.org>.
On 01/04/2015 14:30, Violeta Georgieva wrote:
> Hi,
>
> 2015-04-01 14:41 GMT+03:00 Mark Thomas <ma...@apache.org>:
>>
>> On 01/04/2015 11:45, violetagg@apache.org wrote:
>>> Author: violetagg
>>> Date: Wed Apr 1 10:45:33 2015
>>> New Revision: 1670610
>>>
>>> URL: http://svn.apache.org/r1670610
>>> Log:
>>> Removed debug messages as they do not give any valuable information and
> floods the log files with empty rows. Patch provided by Polina Genova.
>>
>> Are you sure that statement holds for all possible inputs to the
>> digester (server.xml, context.xml, web.xml, TLDs etc.) - both valid and
>> mal-formed?.
>>
>> No objections to removing them if they are always empty but I'm not
>> convinced that that is the case.
>>
>
> Checked with Tomcat 8.0.21 startup with
> logger org.apache.tomcat.util.digester.Digester.level = FINEST
>
> Parsed web.xml, context.xml, server.xml, TLDs in
> examples, mbeans-descriptors -> only new lines are logged.
>
> Then I changes one of the web.xml files of the examples to be invalid ->
> again only new lines. (Digester.fatalError Parse Fatal Error at line 28
> column 5: The end-tag for element type "description" must end with a '>'
> delimiter.)
>
> Any other checks that can be performed?
None that come to mind. Happy to ditch the code on that basis.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1670610 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,
2015-04-01 14:41 GMT+03:00 Mark Thomas <ma...@apache.org>:
>
> On 01/04/2015 11:45, violetagg@apache.org wrote:
> > Author: violetagg
> > Date: Wed Apr 1 10:45:33 2015
> > New Revision: 1670610
> >
> > URL: http://svn.apache.org/r1670610
> > Log:
> > Removed debug messages as they do not give any valuable information and
floods the log files with empty rows. Patch provided by Polina Genova.
>
> Are you sure that statement holds for all possible inputs to the
> digester (server.xml, context.xml, web.xml, TLDs etc.) - both valid and
> mal-formed?.
>
> No objections to removing them if they are always empty but I'm not
> convinced that that is the case.
>
Checked with Tomcat 8.0.21 startup with
logger org.apache.tomcat.util.digester.Digester.level = FINEST
Parsed web.xml, context.xml, server.xml, TLDs in
examples, mbeans-descriptors -> only new lines are logged.
Then I changes one of the web.xml files of the examples to be invalid ->
again only new lines. (Digester.fatalError Parse Fatal Error at line 28
column 5: The end-tag for element type "description" must end with a '>'
delimiter.)
Any other checks that can be performed?
Regards,
Violeta
> Mark
>
> >
> > Modified:
> > tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> >
> > Modified:
tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1670610&r1=1670609&r2=1670610&view=diff
> >
==============================================================================
> > --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
(original)
> > +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed
Apr 1 10:45:33 2015
> > @@ -943,9 +943,6 @@ public class Digester extends DefaultHan
> >
> > // Recover the body text from the surrounding element
> > bodyText = bodyTexts.pop();
> > - if (debug) {
> > - log.debug(" Popping body text '" + bodyText.toString() +
"'");
> > - }
> >
> > // Fire "end" events for all relevant rules in reverse order
> > if (rules != null) {
> > @@ -1148,9 +1145,6 @@ public class Digester extends DefaultHan
> >
> > // Save the body text accumulated for our surrounding element
> > bodyTexts.push(bodyText);
> > - if (debug) {
> > - log.debug(" Pushing body text '" + bodyText.toString() +
"'");
> > - }
> > bodyText = new StringBuilder();
> >
> > // the actual element name is either in localName or qName,
depending
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: svn commit: r1670610 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
Posted by Mark Thomas <ma...@apache.org>.
On 01/04/2015 11:45, violetagg@apache.org wrote:
> Author: violetagg
> Date: Wed Apr 1 10:45:33 2015
> New Revision: 1670610
>
> URL: http://svn.apache.org/r1670610
> Log:
> Removed debug messages as they do not give any valuable information and floods the log files with empty rows. Patch provided by Polina Genova.
Are you sure that statement holds for all possible inputs to the
digester (server.xml, context.xml, web.xml, TLDs etc.) - both valid and
mal-formed?.
No objections to removing them if they are always empty but I'm not
convinced that that is the case.
Mark
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1670610&r1=1670609&r2=1670610&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Apr 1 10:45:33 2015
> @@ -943,9 +943,6 @@ public class Digester extends DefaultHan
>
> // Recover the body text from the surrounding element
> bodyText = bodyTexts.pop();
> - if (debug) {
> - log.debug(" Popping body text '" + bodyText.toString() + "'");
> - }
>
> // Fire "end" events for all relevant rules in reverse order
> if (rules != null) {
> @@ -1148,9 +1145,6 @@ public class Digester extends DefaultHan
>
> // Save the body text accumulated for our surrounding element
> bodyTexts.push(bodyText);
> - if (debug) {
> - log.debug(" Pushing body text '" + bodyText.toString() + "'");
> - }
> bodyText = new StringBuilder();
>
> // the actual element name is either in localName or qName, depending
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org