You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/08 00:55:35 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10348: Reader support seek from separate messageId/time
Anonymitaet commented on a change in pull request #10348:
URL: https://github.com/apache/pulsar/pull/10348#discussion_r628640455
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
void seek(long timestamp) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id.
+ * Reset the subscription associated with this consumer to a specific message id or message publish time.
* <p>
- * The Function input is topic+partition.
+ * The Function input is topic+partition, and can only return timestamp or MessageId.
Review comment:
```suggestion
* The Function input is topic+partition. It returns only timestamp or MessageId.
```
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
void seek(long timestamp) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id.
+ * Reset the subscription associated with this consumer to a specific message id or message publish time.
Review comment:
```suggestion
* Reset the subscription associated with this consumer to a specific message ID or message publish time.
```
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
void seek(long timestamp) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id.
+ * Reset the subscription associated with this consumer to a specific message id or message publish time.
Review comment:
Please check and keep consistencies for all occurencies.
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
void seek(long timestamp) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id.
+ * Reset the subscription associated with this consumer to a specific message id or message publish time.
* <p>
- * The Function input is topic+partition.
+ * The Function input is topic+partition, and can only return timestamp or MessageId.
* <p>
* The return value is the seek position/timestamp of the current partition.
+ * Exception will be thrown if other types of objects are returned.
Review comment:
```suggestion
* Exception is thrown if other object types are returned.
```
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
void seek(long timestamp) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id.
+ * Reset the subscription associated with this consumer to a specific message id or message publish time.
* <p>
- * The Function input is topic+partition.
+ * The Function input is topic+partition, and can only return timestamp or MessageId.
* <p>
* The return value is the seek position/timestamp of the current partition.
+ * Exception will be thrown if other types of objects are returned.
* <p>
* If returns null, the current partition will not do any processing.
+ * Exception in a partition may affect other partitions.
* @param function
* @throws PulsarClientException
*/
void seek(Function<String, Object> function) throws PulsarClientException;
/**
- * Reset the subscription associated with this consumer to a specific message id asynchronously.
+ * Reset the subscription associated with this consumer to a specific message id
Review comment:
```suggestion
* Reset the subscription associated with this consumer to a specific message ID
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org