You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/11/22 23:31:14 UTC
Review Request 64011: Updated master behaviour to update agent state
on reregistration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Diffs
-----
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
Diff: https://reviews.apache.org/r/64011/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192151
-----------------------------------------------------------
src/master/master.cpp
Lines 6913 (patched)
<https://reviews.apache.org/r/64011/#comment270172>
s/because/ because/
src/master/master.cpp
Line 6872 (original), 6923 (patched)
<https://reviews.apache.org/r/64011/#comment270173>
s/command/update/
src/master/master.cpp
Line 6873 (original), 6924 (patched)
<https://reviews.apache.org/r/64011/#comment270175>
s/reset/remove/
src/master/master.cpp
Lines 6928 (patched)
<https://reviews.apache.org/r/64011/#comment270176>
This might need to be removed after the change to upgrade slaveinfo at the very beginning of registration process.
src/master/master.cpp
Line 11174 (original), 11183 (patched)
<https://reviews.apache.org/r/64011/#comment270180>
Make a NOTE that there is a window of time between re-registration and updateslave message where the total could be incorrect.
Instead of basing this on `info` getting updated, put this in a separate if statement that checks if `total` got updated.
- Vinod Kone
On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 6:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64011/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192157
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 6:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64011/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192905
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/hierarchical_allocator_tests.cpp
Line 6283 (original)
<https://reviews.apache.org/r/64011/#comment271248>
Let's actually pause the clock in this test.
- Vinod Kone
On Dec. 5, 2017, 4:14 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 4:14 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
> src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
> src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
> src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
> src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
>
>
> Diff: https://reviews.apache.org/r/64011/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 9:25 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebased onto master.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Note that most tests for this are added in a later review, since they
require the capability to actually restart the agent with
a changed state to effectively test the masters response to that.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 41ffe17def133d7e735afa26a6fedd154e51f4b4
src/master/allocator/mesos/hierarchical.cpp 4bc9fb6f787224114f1285937cf979ace46d8ea3
src/master/master.hpp a721131e8f37e8d872da2b592124d72a19ec1763
src/master/master.cpp e8257e786b411a0f569559526918a6c49c63875a
src/tests/hierarchical_allocator_tests.cpp 154049c47f2dae2df8d1bb4ddb5c48c478bb3d0e
Diff: https://reviews.apache.org/r/64011/diff/10/
Changes: https://reviews.apache.org/r/64011/diff/9-10/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192911
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 5, 2017, 7:03 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 7:03 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 41ffe17def133d7e735afa26a6fedd154e51f4b4
> src/master/allocator/mesos/hierarchical.cpp 4428541e63561f7c3bc3bc61f4b47e35216f6442
> src/master/master.hpp 448be3b4a3eb3d0cbd34a39b19640d15cf3fc2af
> src/master/master.cpp 31991b5f7f7f4e7dc73d71a3160348bfc0a627c3
> src/tests/hierarchical_allocator_tests.cpp 154049c47f2dae2df8d1bb4ddb5c48c478bb3d0e
>
>
> Diff: https://reviews.apache.org/r/64011/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 7:03 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Update test to pause the clock while running and rebase onto latest master.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Note that most tests for this are added in a later review, since they
require the capability to actually restart the agent with
a changed state to effectively test the masters response to that.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 41ffe17def133d7e735afa26a6fedd154e51f4b4
src/master/allocator/mesos/hierarchical.cpp 4428541e63561f7c3bc3bc61f4b47e35216f6442
src/master/master.hpp 448be3b4a3eb3d0cbd34a39b19640d15cf3fc2af
src/master/master.cpp 31991b5f7f7f4e7dc73d71a3160348bfc0a627c3
src/tests/hierarchical_allocator_tests.cpp 154049c47f2dae2df8d1bb4ddb5c48c478bb3d0e
Diff: https://reviews.apache.org/r/64011/diff/9/
Changes: https://reviews.apache.org/r/64011/diff/8-9/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 4:14 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Note that most tests for this are added in a later review, since they
require the capability to actually restart the agent with
a changed state to effectively test the masters response to that.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
Diff: https://reviews.apache.org/r/64011/diff/8/
Changes: https://reviews.apache.org/r/64011/diff/7-8/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 11:43 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Note that most tests for this are added in a later review, since they
require the capability to actually restart the agent with
a changed state to effectively test the masters response to that.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
Diff: https://reviews.apache.org/r/64011/diff/7/
Changes: https://reviews.apache.org/r/64011/diff/6-7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
> On Dec. 4, 2017, 10:05 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 6338 (patched)
> > <https://reviews.apache.org/r/64011/diff/6/?file=1908065#file1908065line6338>
> >
> > I wonder what caused the allocation to happen given you didn't set `updated` to true in `updateSlave` for attribute changes?
Doesn't allocation happen periodically every second or so?
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192773
-----------------------------------------------------------
On Dec. 4, 2017, 4:30 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 4:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
> src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
> src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
> src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
> src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
>
>
> Diff: https://reviews.apache.org/r/64011/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192773
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp
Lines 612 (patched)
<https://reviews.apache.org/r/64011/#comment271026>
`updated = true`
src/master/allocator/mesos/hierarchical.cpp
Line 607 (original), 621 (patched)
<https://reviews.apache.org/r/64011/#comment271027>
see above. this needs to be pulled up to #602?
src/tests/hierarchical_allocator_tests.cpp
Lines 6277 (patched)
<https://reviews.apache.org/r/64011/#comment271028>
`updateSlave()`
src/tests/hierarchical_allocator_tests.cpp
Lines 6338 (patched)
<https://reviews.apache.org/r/64011/#comment271035>
I wonder what caused the allocation to happen given you didn't set `updated` to true in `updateSlave` for attribute changes?
- Vinod Kone
On Dec. 4, 2017, 4:30 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 4:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
> Note that most tests for this are added in a later review, since they
> require the capability to actually restart the agent with
> a changed state to effectively test the masters response to that.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
> src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
> src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
> src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
> src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
>
>
> Diff: https://reviews.apache.org/r/64011/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 4:30 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description (updated)
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Note that most tests for this are added in a later review, since they
require the capability to actually restart the agent with
a changed state to effectively test the masters response to that.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
Diff: https://reviews.apache.org/r/64011/diff/6/
Changes: https://reviews.apache.org/r/64011/diff/5-6/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192535
-----------------------------------------------------------
src/master/master.cpp
Lines 6923-6927 (original), 6894-6898 (patched)
<https://reviews.apache.org/r/64011/#comment270742>
this comment might be stale after your changes in the previous review.
change updateSlave return value to `Try<Nothing>`
src/master/master.cpp
Lines 11439 (patched)
<https://reviews.apache.org/r/64011/#comment270743>
s/reregistering/re-registering/
- Vinod Kone
On Dec. 1, 2017, 6:31 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 6:31 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
> src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e
>
>
> Diff: https://reviews.apache.org/r/64011/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 6:31 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Diffs (updated)
-----
src/master/master.hpp 5d2ae658070d9c5a0bc630c15ff89dc449857f46
src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e
Diff: https://reviews.apache.org/r/64011/diff/5/
Changes: https://reviews.apache.org/r/64011/diff/4-5/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 6:27 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Diffs (updated)
-----
src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
Diff: https://reviews.apache.org/r/64011/diff/4/
Changes: https://reviews.apache.org/r/64011/diff/3-4/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191958
-----------------------------------------------------------
src/master/master.cpp
Lines 6879 (patched)
<https://reviews.apache.org/r/64011/#comment269918>
If the slave state was changed,
src/master/master.cpp
Lines 6884 (patched)
<https://reviews.apache.org/r/64011/#comment269920>
back ticks around `slave->info` and `slaveInfo`
src/master/master.cpp
Lines 6885 (patched)
<https://reviews.apache.org/r/64011/#comment269921>
s/the slave/`slave`/
- Vinod Kone
On Nov. 28, 2017, 12:28 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 12:28 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
> src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
>
>
> Diff: https://reviews.apache.org/r/64011/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 12:28 a.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Diffs (updated)
-----
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
Diff: https://reviews.apache.org/r/64011/diff/3/
Changes: https://reviews.apache.org/r/64011/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 11:30 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
When an agent reregisters, the master will now always update
the agent information it holds in memory, and will write any
changes back to the registry if necessary.
Diffs (updated)
-----
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
Diff: https://reviews.apache.org/r/64011/diff/2/
Changes: https://reviews.apache.org/r/64011/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Line 6672 (original), 6609 (patched)
> > <https://reviews.apache.org/r/64011/diff/1/?file=1900319#file1900319line6699>
> >
> > Reject if agent is being marked gone or already marked gone. Can you do this and the previous similar change in a separate review?
https://reviews.apache.org/r/64169/
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191767
-----------------------------------------------------------
On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 6:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64011/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Lines 6323 (patched)
> > <https://reviews.apache.org/r/64011/diff/1/?file=1900319#file1900319line6323>
> >
> > Can you file a JIRA for this?
https://issues.apache.org/jira/browse/MESOS-8273
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191767
-----------------------------------------------------------
On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 6:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64011/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64011: Updated master behaviour to update agent
state on reregistration.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191767
-----------------------------------------------------------
src/master/master.hpp
Lines 1105 (patched)
<https://reviews.apache.org/r/64011/#comment269647>
s/agentCapabilities/capabilities/
src/master/master.cpp
Lines 6320 (patched)
<https://reviews.apache.org/r/64011/#comment269649>
s/reregistration/re-registration/
src/master/master.cpp
Lines 6321 (patched)
<https://reviews.apache.org/r/64011/#comment269648>
s/. (/(/
s/)/)./
s/state/SlaveInfo/
src/master/master.cpp
Lines 6323 (patched)
<https://reviews.apache.org/r/64011/#comment269650>
Can you file a JIRA for this?
src/master/master.cpp
Line 6478 (original), 6484 (patched)
<https://reviews.apache.org/r/64011/#comment269655>
Can you make sure to reject re-registration here if the slave is in `markingGone` or `gone` maps.
src/master/master.cpp
Lines 6489-6490 (patched)
<https://reviews.apache.org/r/64011/#comment269651>
s/in cases 1 and 2//
src/master/master.cpp
Line 6489 (original), 6501 (patched)
<https://reviews.apache.org/r/64011/#comment269652>
log the pid and hostname.
src/master/master.cpp
Line 6610 (original), 6543 (patched)
<https://reviews.apache.org/r/64011/#comment269653>
log the pid and hostname.
src/master/master.cpp
Lines 6626-6627 (original), 6559-6560 (patched)
<https://reviews.apache.org/r/64011/#comment269654>
Remove the first sentence.
s/In the common case,/In the common case, we are here if/
src/master/master.cpp
Line 6659 (original), 6594 (patched)
<https://reviews.apache.org/r/64011/#comment269656>
s/success/future/
src/master/master.cpp
Line 6672 (original), 6609 (patched)
<https://reviews.apache.org/r/64011/#comment269657>
Reject if agent is being marked gone or already marked gone. Can you do this and the previous similar change in a separate review?
src/master/master.cpp
Lines 6847 (patched)
<https://reviews.apache.org/r/64011/#comment269658>
Reject if slave is marking gone or marked gone.
src/master/master.cpp
Lines 6854 (patched)
<https://reviews.apache.org/r/64011/#comment269659>
log the pid and hostname.
src/master/master.cpp
Lines 6861-6871 (patched)
<https://reviews.apache.org/r/64011/#comment269662>
Change this to:
```
CHECK_READY(updated);
CHECK(updated.get());
VLOG(1) << Registry updated for slave " < slaveInfo.id << " at " << pid << " (" slaveInfo.hostname() << ")";
```
src/master/master.cpp
Lines 6873 (patched)
<https://reviews.apache.org/r/64011/#comment269663>
s/failoverSlave()/`failoverSlave()`/
Can you expand a bit on the comment for future reference?
src/master/master.cpp
Lines 6901-6902 (patched)
<https://reviews.apache.org/r/64011/#comment269664>
indentation?
can you update the comment to not say anything about checkpoint resources. say instead that you would recover the framework info if necessary.
src/master/master.cpp
Line 6943 (original), 6997 (patched)
<https://reviews.apache.org/r/64011/#comment269666>
just inline it.
src/master/master.cpp
Line 11091 (original), 11146 (patched)
<https://reviews.apache.org/r/64011/#comment269667>
2 blank lines.
src/master/master.cpp
Lines 11147 (patched)
<https://reviews.apache.org/r/64011/#comment269668>
return `Try<Nothing>` here instead and reject re-registration if it's an error.
src/master/master.cpp
Lines 11170 (patched)
<https://reviews.apache.org/r/64011/#comment269669>
s/ slave/slave/
- Vinod Kone
On Nov. 22, 2017, 11:31 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2017, 11:31 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
> src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
>
>
> Diff: https://reviews.apache.org/r/64011/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>