You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2018/08/22 15:01:38 UTC

[GitHub] zeppelin pull request #3159: [WIP][ZEPPELIN-3733] Refactor `Notebook*` class...

GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/3159

    [WIP][ZEPPELIN-3733] Refactor `Notebook*` classes to remove circular dependencies and several listeners

    ### What is this PR for?
    Decoupling `Notebook*` classes as they depend each others. it makes circular dependencies, and it bothers that contributors understand code.
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3733
    
    ### How should this be tested?
    CI passes
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3733

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3159
    
----
commit 31d78d79b739734befd163fb59585802fd57b92e
Author: Jongyoul Lee <jo...@...>
Date:   2018-08-20T16:02:29Z

    Add trick to fix tests (+9 squashed commits)
    Squashed commits:
    [807e286] Fix tests
    [3b6ad26] Fix style
    Remove unused code
    [2dc0946] Fix style
    [7e96118] Remove unused code
    [472696d] Remove unused code
    [0ff6bdb] Change `ParagraphJobListener` from a parameter of constructor to setter
    Add code to enable `NotebookService` to set `ParagraphJobListener` into `Notebook`
    Add code to inject `NotebookServer` to `NotebookService`
    Add conservative logic to prepare the case where `ParagraphJobListener` is null
    [e97e165] Fix `NotebookServerTest`
    [1eccc3c] Change scopes for some bound classes
    [4c662c9] Add more injection code in NotebookRestApi
    Bind `NotebookAuthorization` and `NotebookService`
    Provide `getInstance()` of `ConfigurationService` and `NotebookService` to let `NotebookServer` call them

----


---

[GitHub] zeppelin issue #3159: [ZEPPELIN-3733] Refactor `Notebook*` classes to remove...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3159
  
    Ready to review. This PR is for refactoring only. It doesn't change any behavior at all. I'll merge if this PR passes CI correctly.


---

[GitHub] zeppelin pull request #3159: [ZEPPELIN-3733] Refactor `Notebook*` classes to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3159


---