[jira] [Commented] (KAFKA-15342) Considering upgrading to Mockito 5.4.1 or later

["Chia-Ping Tsai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841294#comment-17841294 ] 

Chia-Ping Tsai commented on KAFKA-15342:
----------------------------------------

not sure the benefit of having unit test and integration test. Our CI always run all tests regardless of fast failure. The difference of JVM setting is `maxHeapSize` (2g v.s 2560m), but I don't think that is something important. Also, we often neglect the tag in testing. 

Maybe we should just get rid of the category :_

 

> Considering upgrading to Mockito 5.4.1 or later
> -----------------------------------------------
>
>                 Key: KAFKA-15342
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15342
>             Project: Kafka
>          Issue Type: Task
>          Components: unit tests
>            Reporter: Chris Egerton
>            Assignee: Chris Egerton
>            Priority: Blocker
>             Fix For: 4.0.0
>
>
> We're currently stuck on Mockito 4.x.y because the 5.x.y line requires Java 11 and, until we begin to work on Kafka 4.0.0, we continue to support Java 8.
> Either directly before, or after releasing Kafka 4.0.0, we should try to upgrade to a version of Mockito on the 5.x.y line.
> If we're able to use a version that includes [https://github.com/mockito/mockito/pull/3078|https://github.com/mockito/mockito/pull/3078,] (which should be included in either a 5.4.1 or 5.5.0 release), we should also revert the change made for https://issues.apache.org/jira/browse/KAFKA-14682, which is just a temporary workaround. Care should be taken that, after reverting that change, unused stubbings are still correctly reported during our CI builds.
> If the effort required to upgrade our Mockito version is too high, we can either downgrade the severity of this ticket, or split it out into separate subtasks for each to-be-upgraded module.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)