[GitHub] [spark] LuciferYang commented on a diff in pull request #41377: [DRAFT] Generate Protobuf descriptor files at build time.

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41377:
URL: https://github.com/apache/spark/pull/41377#discussion_r1210401764


##########
project/SparkBuild.scala:
##########
@@ -929,7 +929,12 @@ object SparkProtobuf {
     (Test / PB.protoSources) += (Test / sourceDirectory).value / "resources" / "protobuf",
 
     (Test / PB.targets) := Seq(
-      PB.gens.java -> target.value / "generated-test-sources"
+      PB.gens.java -> target.value / "generated-test-sources",
+      PB.gens.descriptorSet -> target.value / "generated-test-sources/descriptor-set-sbt.desc",

Review Comment:
   I'll take a look at this one tomorrow
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org